vignettes: explain proportional baseline#70
Open
carmen-cabrera wants to merge 1 commit into
Open
Conversation
fcorowe
reviewed
Jun 15, 2026
fcorowe
left a comment
Collaborator
There was a problem hiding this comment.
This is looking good overall, and the new visual addresses #67 nicely. I found one small wording issue to tighten before merge: the prose should distinguish the count residual from the default selected residual returned by validate_bias_residual_structure().
|
|
||
| We can use the function `validate_bias_residual_structure()` from `debiasR` to estimate this proportional baseline and inspect the | ||
| residual structure, i.e. the differences between observed and expected user counts. | ||
| `debiasR::validate_bias_residual_structure()` calculates this baseline and |
Collaborator
There was a problem hiding this comment.
Small wording fix before merge: this paragraph says the function returns residuals as observed-minus-expected user counts, but the default selected residual from validate_bias_residual_structure() is coverage_score_residual. Could we rephrase to make both residual concepts explicit?
Suggested replacement:
`debiasR::validate_bias_residual_structure()` calculates this baseline and
returns expected user counts plus several residual measures for each LAD. These
include count residuals, defined as observed user counts minus the counts
expected under constant coverage, and the default `coverage_score_residual`,
defined as local coverage minus overall coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checks
git diff --checkCloses #67