New user registration route 2153372#4
Closed
dcDalin wants to merge 5 commits into
Closed
Conversation
mkiterian
reviewed
Mar 6, 2018
|
|
||
| def __init__(self): | ||
| '''Constructor method, will have dictionaries in a list''' | ||
| self.users_counter = 0 |
There was a problem hiding this comment.
Why have this? Can't you just get the length of the users list?
Owner
Author
There was a problem hiding this comment.
Performance I guess. Checking the value of the counter then adding 1 instead of checking for the length of the list each time.
mkiterian
reviewed
Mar 6, 2018
|
|
||
| from flask import request | ||
| from flask_restplus import Resource | ||
| from WeConnect_RestAPI.api.we_connect.serializers import new_user_structure, login_structure, logout_structure, reset_pass_structure |
There was a problem hiding this comment.
There was a problem hiding this comment.
Ensure your code adheres to PEP8 standards
mkiterian
reviewed
Mar 6, 2018
|
|
||
| from WeConnect_RestAPI.app import app as the_app, initialize_app | ||
|
|
||
| class TestSomething(unittest.TestCase): |
There was a problem hiding this comment.
Use a more meaningful and descriptive test file name and testcase name
mkiterian
suggested changes
Mar 6, 2018
mkiterian
left a comment
mkiterian
left a comment
There was a problem hiding this comment.
Cached files should be added to gitignore
mkiterian
reviewed
Mar 6, 2018
|
|
||
| @api.expect(new_user_structure) | ||
| @api.doc(responses={403: 'Not Authorized', 404: 'Not Found', 201: 'User added', 400: 'Bad request'}) | ||
| #@api.expect(NEW_USER_STRUCTURE, validate=True, code=201) |
mkiterian
reviewed
Mar 6, 2018
| """ | ||
| Returns all users. | ||
| """ | ||
| return initWeConnectUsers.show_all_users() No newline at end of file |
Fix raised issues on the pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows new users to create an account
Description of Task to be completed?
A new user should be able to fill in their credentials and create an account
How should this be manually tested?
Clone the repository, create your virtual environment, run requirements.txt then run app.py
Any background context you want to provide?
What are the relevant pivotal tracker stories?
#155732737