Simplify 'ModelElement.filtering_criteria'#558
Merged
Conversation
Wuestengecko
force-pushed
the
filtering-criteria-accessor
branch
from
July 1, 2025 14:09
d87eb0f to
53c66f4
Compare
Wuestengecko
force-pushed
the
filtering-criteria-accessor
branch
3 times, most recently
from
July 11, 2025 11:38
eed64b4 to
185a1a5
Compare
Use a simple property and `ElementList.map()` instead of a specialized, single-use Accessor subclass.
Wuestengecko
force-pushed
the
filtering-criteria-accessor
branch
from
July 14, 2025 14:41
185a1a5 to
d9b208a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a simple property and
ElementList.map()instead of a specialized, single-use Accessor subclass.