fix: Update update_student_comment.php to the new moodle classes for …

[hamzakhalem]

…external

to fix : Coding error detected, it must be fixed by a programmer: mod_checklist\external\update_item_state::execute_parameters did not return a valid external_function_parameters object

[davosmith]

Thanks for reporting. Clearly this is an area where I'm missing a Behat test to cover it.

I'll need to write such a test, to confirm your fix (and avoid similar issues in the future), but will be a few days (at least) before I have a chance to do so. If you had time to add a Behat test that demonstrated the error, then that would be greatly appreciated.

[davosmith]

@hamzakhalem - I've finally had a chance to look at this and I've added a Behat test that covers student comments.

Unfortunately, I've been unable to reproduce the error you have reported. In Moodle versions up to and including Moodle 5.1, there are class aliases that mean that the old \external_api, etc. classes still work (as an alias to \core_external\external_api, etc.).

Once these stop working (presumably in Moodle 6.0), I'll update the external functions, but until then, I'd rather maintain compatibility with Moodle 4.1 (and below), which does not have the newer versions.

If you check https://github.com/davosmith/moodle-checklist/actions - you should be able to see that this is working, without your patch, for Moodle 4.1 => Moodle 5.1.

Is there something specific that is causing you problems with this?