Repository navigation
chore(deps-dev): bump the dev-dependencies group across 1 directory with 8 updates - #589
dependabot[bot] wants to merge 1 commit into
Conversation
…ith 8 updates Bumps the dev-dependencies group with 8 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@cloudflare/workers-types](https://github.com/cloudflare/workerd) | `5.20261021.1` | `5.20261110.1` | | [@fedify/fedify](https://github.com/fedify-dev/fedify/tree/HEAD/packages/fedify) | `2.4.4` | `2.4.5` | | [@fedify/vocab](https://github.com/fedify-dev/fedify/tree/HEAD/packages/vocab) | `2.4.4` | `2.4.5` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `26.6.5` | `26.6.6` | | [eslint](https://github.com/eslint/eslint) | `10.13.0` | `10.14.0` | | [prettier](https://github.com/prettier/prettier) | `3.9.10` | `3.10.0` | | [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) | `8.72.0` | `8.72.2` | | [wrangler](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/wrangler) | `4.151.3` | `4.160.1` | Updates `@cloudflare/workers-types` from 5.20261021.1 to 5.20261110.1 - [Release notes](https://github.com/cloudflare/workerd/releases) - [Changelog](https://github.com/cloudflare/workerd/blob/main/RELEASE.md) - [Commits](https://github.com/cloudflare/workerd/commits) Updates `@fedify/fedify` from 2.4.4 to 2.4.5 - [Release notes](https://github.com/fedify-dev/fedify/releases) - [Changelog](https://github.com/fedify-dev/fedify/blob/main/CHANGES.md) - [Commits](https://github.com/fedify-dev/fedify/commits/2.4.5/packages/fedify) Updates `@fedify/vocab` from 2.4.4 to 2.4.5 - [Release notes](https://github.com/fedify-dev/fedify/releases) - [Changelog](https://github.com/fedify-dev/fedify/blob/main/CHANGES.md) - [Commits](https://github.com/fedify-dev/fedify/commits/2.4.5/packages/vocab) Updates `@types/node` from 26.6.5 to 26.6.6 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `eslint` from 10.13.0 to 10.14.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.13.0...v10.14.0) Updates `prettier` from 3.9.10 to 3.10.0 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.9.10...3.10.0) Updates `typescript-eslint` from 8.72.0 to 8.72.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.72.2/packages/typescript-eslint) Updates `wrangler` from 4.151.3 to 4.160.1 - [Release notes](https://github.com/cloudflare/workers-sdk/releases) - [Commits](https://github.com/cloudflare/workers-sdk/commits/wrangler@4.160.1/packages/wrangler) --- updated-dependencies: - dependency-name: "@cloudflare/workers-types" dependency-version: 5.20261110.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: "@fedify/fedify" dependency-version: 2.4.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: "@fedify/vocab" dependency-version: 2.4.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: "@types/node" dependency-version: 26.6.6 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: eslint dependency-version: 10.14.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: prettier dependency-version: 3.10.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: typescript-eslint dependency-version: 8.72.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: wrangler dependency-version: 4.160.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
davidwkeith
left a comment
There was a problem hiding this comment.
Review: changes requested
Blocking: CI fails. The @cloudflare/workers-types bump to 5.20261110.1 makes mapVirtualHost a required member of ExecutionContext. HostExecutionContext in @dwk/server doesn't implement it, so typecheck and build fail, which also fails the build-test, integration and image jobs. The inline comment has a fix that follows #572.
Local results on head 34be4a4:
pnpm install --frozen-lockfile: ✅pnpm lint: ✅pnpm format:check: ✅ (Prettier 3.10.0 doesn't change any formatting)pnpm typecheck: ❌ onlypackages/serverfailspnpm build: ❌ same cause
CONTRIBUTING.md conformance
- PR body / template: the body is Dependabot's release notes, not
.github/PULL_REQUEST_TEMPLATE.md. CONTRIBUTING.md §7 requires theSummary,Packages affectedandChecklistheadings. Dependabot can't fill these in, so whoever pushes the@dwk/serverfix should rewrite the body from the template. Leave items that don't apply unchecked with a one-line reason, for example "changeset — not applicable, devDependencies only". - Changeset: none needed. Every change is a
devDependencyor the root toolchain, so no publishable package's runtime surface changes. If the fix toHostExecutionContextgoes in,@dwk/serverisprivate, so it doesn't need one either. - Title:
chore(deps-dev): …follows Conventional Commits. Strictly, CONTRIBUTING.md says the scope should be a package name, or left out for a repo-wide change, sodeps-devdoesn't fit. History already accepts this Dependabot convention (#572), so this is optional. If you want it to match exactly, setcommit-message.prefix: "chore"in.github/dependabot.yml. Otherwise you could retitle the PR when you push the fix, e.g.chore(server): bump dev-dependencies group and implement ExecutionContext.mapVirtualHost, the way #572 was titled.
Lockfile notes (not blocking)
@opentelemetry/apimoves back from 1.10.0 to 1.9.1. That's expected: fedify 2.4.5 deliberately keeps it within the range the OpenTelemetry SDK supports (fedify-dev/fedify#1324).@napi-rs/wasm-runtimealso moves back, from 1.2.5 to 1.1.6, a transitive dependency under rolldown. This is probably harmless, but it's worth a glance after you rebase in case another bump on main raises it again.- The fedify 2.4.5 DNS-rebinding SSRF fix (GHSA-r48c-xx2h-fv4g) only affects fedify's own Node/Bun fetch path. Our packages use
@dwk/safe-fetchfor outbound fetches, and fedify is a root devDependency here, so the advisory doesn't apply to us. The upgrade is still worth taking.
Generated by Claude Code
| }, | ||
| "devDependencies": { | ||
| "@cloudflare/workers-types": "5.20261021.1", | ||
| "@cloudflare/workers-types": "5.20261110.1", |
There was a problem hiding this comment.
Blocking: this bump breaks typecheck and build for @dwk/server. CI shows the same failures (build-test, integration and image all fail).
@cloudflare/workers-types 5.20261110.1 adds a required member to ExecutionContext:
mapVirtualHost(fetcher: Fetcher, port: number): string;HostExecutionContext in packages/server/src/context.ts:48 doesn't implement it, so you get:
src/context.ts(48,14): error TS2420: Class 'HostExecutionContext' incorrectly implements interface 'ExecutionContext<unknown>'.
Property 'mapVirtualHost' is missing in type 'HostExecutionContext' but required in type 'ExecutionContext<unknown>'.
followed by TS2345 at lifecycle.ts:57, lifecycle.ts:71, server.ts:340 and web-socket-upgrade.ts:151.
Suggested fix, following what #572 did for abort: add a stub that throws, next to tracing, exports and abort:
/**
* Cloudflare's virtual-host mapping API (added to `ExecutionContext` in
* `@cloudflare/workers-types` 5.20261110). The Node host has no
* service-binding fetchers to map, so, like `tracing`, `exports` and
* `abort`, calling it throws rather than silently doing nothing.
*/
mapVirtualHost(_fetcher: Fetcher, _port: number): string {
throw new Error(
"mapVirtualHost is not supported on the @dwk/server Node host",
);
}I ran pnpm -r --no-bail typecheck locally and @dwk/server is the only package that fails. Lint and format:check pass, including with Prettier 3.10.0.
Generated by Claude Code
Bumps the dev-dependencies group with 8 updates in the / directory:
5.20261021.15.20261110.12.4.42.4.52.4.42.4.526.6.526.6.610.13.010.14.03.9.103.10.08.72.08.72.24.151.34.160.1Updates
@cloudflare/workers-typesfrom 5.20261021.1 to 5.20261110.1Commits
Updates
@fedify/fedifyfrom 2.4.4 to 2.4.5Release notes
Sourced from @fedify/fedify's releases.
Changelog
Sourced from @fedify/fedify's changelog.
... (truncated)
Commits
daf84e3Merge tag '2.3.15' into 2.4-maintenancee174063Merge tag '2.2.20' into 2.3-maintenance0777faaMerge tag '2.1.31' into 2.2-maintenancefc72547Merge tag '2.0.35' into 2.1-maintenanced176ea2Accept decoded colons in HTTP route variablesa87a1d3Pin outbound connections to validated addresses on Bun7c65ca7Cover trace summary recovery and reexports34b42b1Compute getRecentTraces() straight from retained records4478836Prefer Node.js in package documentationbd2e373Clarify null signing-key owner resultsUpdates
@fedify/vocabfrom 2.4.4 to 2.4.5Release notes
Sourced from @fedify/vocab's releases.
Changelog
Sourced from @fedify/vocab's changelog.
... (truncated)
Commits
daf84e3Merge tag '2.3.15' into 2.4-maintenancee174063Merge tag '2.2.20' into 2.3-maintenance0777faaMerge tag '2.1.31' into 2.2-maintenancefc72547Merge tag '2.0.35' into 2.1-maintenancea87a1d3Pin outbound connections to validated addresses on Bun0c5c366Version bump369819cVersion bump1506be4Version bump8191f41Version bumpb27d9a5Version bumpUpdates
@types/nodefrom 26.6.5 to 26.6.6Commits
Updates
eslintfrom 10.13.0 to 10.14.0Release notes
Sourced from eslint's releases.
Commits
12cbff410.14.06b696e7Build: changelog update for 10.14.00e2ab70ci: disableeslint-plugin-unicornecosystem test (#21462)4a12580fix: require minimatch10.2.6to avoid vulnerable brace-expansion (#21460)0f94f47docs: removezh-hansfrom docs language switcher (#21437)dab466edocs: Update README827a8f3fix:no-restricted-globalscrash on global objects as property values (#21449)97431f8docs: replace--rulesdirwith a virtual plugin in custom rules docs (#21452)6e3f988chore: update github/codeql-action action to v4.39.1 (#21450)161558afix: handle LS, PS and empty hashbang comments (#21419)Updates
prettierfrom 3.9.10 to 3.10.0Release notes
Sourced from prettier's releases.
Changelog
Sourced from prettier's changelog.
Commits
b688380Release 3.10.0901fdfaRelease@prettier/plugin-hermes@0.2.4,@prettier/plugin-oxc@0.2.4, and@prett...7e979d0Update dependency@prettier/clito v0.12.4 (#20452)b8863d4Add parentheses around unary expressions and type assertions that end with a ...6022451Fix extra blank line before YAML end comments after a trailing comment (#20371)9b547d3Remove dead code (#20354)90a2c0bCache parsed.editorconfigfiles acrossresolveConfig()(#20462)4e2ff8bLock file maintenance (#20487)27718c6Drop an useless Doc array (#20489)4ebb160ReuseprintArgumentsin graphql plugin (#20488)Updates
typescript-eslintfrom 8.72.0 to 8.72.2Release notes
Sourced from typescript-eslint's releases.
Changelog
Sourced from typescript-eslint's changelog.
Commits
12e452fchore(release): publish 8.72.24ad6b75chore(release): publish 8.72.17757694chore: cleanup typecheck & build and fix race condition (#13071)Updates
wranglerfrom 4.151.3 to 4.160.1Release notes
Sourced from wrangler's releases.
... (truncated)
Commits
cc238b2Version Packages (#16814)d434f33[miniflare] [wrangler] Parallelize the tests workerd's CI runs (#16823)5966749[vitest-plugin] Support Container tests with cloudflare.config.ts (#16682)2674eefVersion Packages (#16799)022ee9d[containers-shared] Defer local image cleanup to upload callers (#16709)cb9534f[wrangler] Support forwarded dev options in cf-wrangler (#16760)44b39b0[wrangler, workers-utils, containers-shared, miniflare] Sanitize header diagn...6af492e[wrangler, workers-utils, containers-shared] Add custom Cloudflare API header...bf3ec7bVersion Packages (#16729)dc4e093[wrangler] Only mention a verification email when the created address is unve...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions