Skip to content

Fix efficiency formula#2

Open
jaisharma639 wants to merge 1 commit into
davidfoliveira:masterfrom
jaisharma639:master
Open

Fix efficiency formula#2
jaisharma639 wants to merge 1 commit into
davidfoliveira:masterfrom
jaisharma639:master

Conversation

@jaisharma639

Copy link
Copy Markdown

No description provided.

Comment thread memcached-tool-ng
foreach my $p ( keys %{$defaultStats} ) {
$it->{$p} = $defaultStats->{$p} if ! defined $it->{$p};
}
$totMemory += $it->{total_pages}*$item_size_max;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jai! Thanks for your contribution. Just out of curiosity, did you see the comment on line #263 about the -I parameter? Is that outdated? Thanks.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for memcached-tool-ng .

As per memcached/memcached#1094 (comment)

  • Pages are fixed at 1mb in size.

I think since version 1.4.29 , released on 2016 July 13th

https://github.com/memcached/memcached/wiki/ReleaseNotes1429#new-features

"The maximum slab chunk size is no longer tied to the maximum item size."

Chunked (large) item support - https://github.com/memcached/memcached/pull/181/files#diff-e471fd56f09dcb25f96a32a2645c4511b65a12fb4cda7fced63d379789050f76R229

memcached.c

  settings.slab_page_size = 1024 * 1024; /* chunks are split from 1MB pages. */

I needed the changes in this PR for memcached-tool-ng to work correctly with memcached version 1.5.10 running with the "-I 21495808" option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants