Feat: start TUI immediately with async baresip connection#13
Merged
davidborzek merged 1 commit intoJun 15, 2026
Merged
Conversation
|
any update on this @davidborzek? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
tui::runblocked onwait_for_port(polling baresip's ctrl_tcp port for up to 5s) andTcpStream::connectbefore the terminal was set up. If baresip was slow to come up, the previous screen stayed visible and the UI was unresponsive for a moment; if it never came up, the user got an opaque error after the timeout.This change starts the TUI immediately and connects to baresip asynchronously in the background:
run_baresip_ioasync task: retriesTcpStream::connectfor up to 10s, then spawns the existing reader/writer tasks.AppEvent::BaresipConnectFailed { reason }event surfaces connect-timeout failures in the UI asRegStatus::Failedwith the reason (including the baresip log path).Unknown(now "Connecting") state uses theattentioncolor so the in-progress connection is visible.wait_for_porthelper and synchronous port-readiness check fromBaresip::spawn.BaresipConnectFailedis emitted with port and log path in the reason).Test plan
cargo buildcleancargo testpasses (incl. newconnect_failure_emits_baresip_connect_failed)