Replace Webpack, update to Node 24#1269
Conversation
datenanfragen/website
 |
||||||||||||||||||||||||||||
| Project |
datenanfragen/website
|
| Branch Review |
webpack-node-staging
|
| Run status |
|
| Run duration | 04m 55s |
| Commit |
|
| Committer | Benjamin Altpeter |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
2
|
 |
8
|
 |
0
|
 |
84
|
| View all changes introduced in this branch ↗︎ | |
|
I had some problems with hugo server not properly rebuilding the site when working on new preact components, but that might have been a user error :D |
* Update to Hugo v0.140.0 This release brings various useful new esbuild features. * Migrate JS bundles from Webpack to Hugo esbuild * properly set NODE_ENV, fix PDF worker bundle URL * code splitting using js.Batch * wait for HTTP instead of TCP * replace webpack-i18n-loader * mostly use defines instead of generating scripts using Hugo templates * Webpack be gone \o/ * Fixes #871: Remove `requests` scope from `I18N_DEFINITION` * build-i18n: EN may affect translations for other langs * address review * build-i18n: unlink and fix allTranslations bug
Co-authored-by: Benjamin Altpeter <hi@bn.al>
baltpeter
force-pushed
the
webpack-node-staging
branch
from
84dc383 to
d1837c4
Compare
|
Ugh. Why is the build suddenly failing in CI when in wasn't before and I didn't touch anything that should affect it? |
|
Yesterday, rebuilds had the same error, today it worked. Maybe a broken cache? |
| cy.visit(site); | ||
| // TODO: undo this once we've seen it pass in CI | ||
| // cy.onlyOn('production'); | ||
|
|
There was a problem hiding this comment.
Passed! And the new test replay looks quite useful.
baltpeter
force-pushed
the
webpack-node-staging
branch
from
4bb07af to
3d051df
Compare
|
Well, I guess this is ready for review now. Let me know if I forgot about anything. As with #1212, this requires a very careful review by both @zner0L and @mal-tee, especially considering that we still missed some stuff in #1212 (#1205 (comment), #1205 (comment), 3d051df). Also, please don't merge immediately after approving. I would like to squash 3d051df into 7c82b59 but didn't do that yet to make review easier. |
| // (https://github.com/datenanfragen/website/issues/1043#issuecomment-1472355575, | ||
| // https://github.com/datenanfragen/website/issues/1043#issuecomment-1472476245). | ||
| // it('loads company from slug and clears URL parameters afterwards', () => { |
There was a problem hiding this comment.
maybe not for this PR, but we can give it another shot after merging this?
mal-tee
left a comment
mal-tee
left a comment
There was a problem hiding this comment.
Thank you! Can you bump cypress to 15.4.1 before merging?
Running cypress locally gives me this nice console warning. The whole test seems to be kinda cursed. How should we adress this? :)
The browser(?) VM also complains a lot about bad HTML tables, but this is a problem for another issue.
|
|
||
| // The blur should fix the flaking here: https://github.com/cypress-io/cypress/issues/5830 | ||
| cy.get('#aa-search-input').type('1&1').blur(); | ||
| cy.get('#aa-search-input').type('1&1', { force: true }); |
There was a problem hiding this comment.
According to the issue (why did you remove the link?) it looks like both blur and force are hotfixes. Why change this?
3 participants
This should be rebase merged (once done).