Skip to content

added non-collaborative file based#237

Open
emekaokoli19 wants to merge 1 commit into
datalayer:mainfrom
emekaokoli19:add_test_fixture_non_collaborative
Open

added non-collaborative file based#237
emekaokoli19 wants to merge 1 commit into
datalayer:mainfrom
emekaokoli19:add_test_fixture_non_collaborative

Conversation

@emekaokoli19

Copy link
Copy Markdown

Add test fixture for non-collaborative (file-based) code path

This PR introduces a new test fixture to exercise the non-collaborative (file-based) execution path for Jupyter cell mutation tools, addressing the gap described in issue #224.

Key changes:

  • Added jupyter_server_no_collab fixture to start Jupyter without collaboration enabled.
  • Extended test parametrization to include a new mode: jupyter_extension_no_collab.
  • Updated test logic to correctly handle tool availability differences between collaborative (YDoc) and non-collaborative modes.

@echarles

Copy link
Copy Markdown
Member

Thx for opening a PR @emekaokoli19 - CI is showing red, could you take a look?

@emekaokoli19

Copy link
Copy Markdown
Author

Thx for opening a PR @emekaokoli19 - CI is showing red, could you take a look?

Yea tests/test_otel_integration.py seems to be failing in the CI, although it passes locally when I run the tests. I will take a closer look.

@abbbe

abbbe commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

The failures are due to some awkwardness of the otel-related test harnesses. @emekaokoli19 chances are you were probably testing against some intermediate version, with otel feature added with partial test coverage or something. I have reworked the test harnesses to let otel and non-collaborative tests coexist, my version is here -- abbbe#4. Unfortunately, I saw no easy way to fix it and keep the test suite clean and legible, so changes are quite extensive... Unless you have better ideas, feel free to merge into your branch & tests or whatever.

@abbbe

abbbe commented May 5, 2026

Copy link
Copy Markdown
Contributor

@emekaokoli19 are you ok with the modifications to your PR I have proposed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants