Conversation
zaptot
marked this pull request as ready for review
October 1, 2026 16:28
zaptot
requested review from
kolina and
rafal-hawrylak
and removed request for
a team
October 1, 2026 16:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds protobuf definitions required to support project-level
defaultJobLabelsand action-leveljobLabelsfor BigQuery jobs (split out from #2344 so schema changes can be imported prior to the compiler/CLI implementation).Changes
protos/core.proto:ProjectConfig.default_job_labels = 26(map<string, string>)ActionDescriptor.job_labels = 7(map<string, string>) for resolved effective job labels (default_job_labelsmerged with and overridden by action-leveljob_labels)Test.action_descriptor = 11,DataPreparation.action_descriptor = 17, andPropertyGraph.action_descriptor = 11(ActionDescriptor) so all BigQuery-executing actions carry anActionDescriptorprotos/configs.proto:WorkflowSettings.default_job_labels = 20(map<string, string>)job_labels(map<string, string>) onTableConfig(26),ViewConfig(22),IncrementalTableConfig(31),AssertionConfig(13),OperationConfig(14), andDataPreparationConfig(15)protos/property_graph_config.proto:PropertyGraphConfig.job_labels = 9(map<string, string>)