Repository navigation
Windows follow-up to #591: recovery UI smoke fix, PPT EPERM and zip path fixes - #618
Merged
Merged
Conversation
The smoke still closed the WebContentsView menu it no longer creates, failing on Windows with 'menu is not defined'. Stub the new popup IPC instead of the removed close-menu channel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… into feat/windows-electron-node-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#591 was merged at
a398ece9d6, before these commits reached it. Its last CI run failed in the Windows "Check recovery UI on native Windows at three display scales" step withReferenceError: menu is not defined, somainnow carries that failure.This follow-up brings over the remaining commits from the same branch:
cc36694f25test(windows): drop the removed menu view from the recovery UI smoke. When Windows: Electron Node mode, loader packaging gate, and upstream sidebar collapse #591 removed the Windows menu view,scripts/recovery-ui-smoke.tsstill closed it. The smoke now stubs the newdesktop-titlebar:popup-menuIPC in place of the removedclose-menuchannel.scripts/is outsidenpm run typecheck, which is why this was not caught locally.dee2e0297afix(build): invoke ppt runCli directly to prevent spawn EPERM on Windows, pushed to the Windows: Electron Node mode, loader packaging gate, and upstream sidebar collapse #591 branch after it was reviewed.346da6e708fix(zip): normalize Windows backslash path separators in OOXML and preset archives, pushed to the Windows: Electron Node mode, loader packaging gate, and upstream sidebar collapse #591 branch after it was reviewed.Validation
node scripts/check-recovery-ui.mjspasses locally on macOS at scales 1, 1.25 and 1.5 (40 variants each).npm run typecheckandnpm test(157 files / 1,293 tests) pass on the merged branch head.🤖 Generated with Claude Code