test: derive dependency patch hunk counts dynamically - #574
Merged
Merged
Conversation
Replace a hardcoded hunk header string in the patch-hunk-counts test with a dynamic regex replacement that locates the first hunk in the package.json section of the dsh patch, so the test remains valid across Harness version upgrades.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更
将
patch-hunk-counts测试中硬编码的 hunk header 字符串替换为动态正则匹配，先定位@deepseek-ai/dshpatch 中package.json部分的第一个 hunk，再对行数做减一处理。这样测试在 Harness 版本升级后无需手动更新硬编码的行号。
文件
test/patch-hunk-counts.test.ts：1 个文件，8 行变更