fix: SQL quality rules on mysql/iceberg read as DuckDB SQL - #1663
Merged
Merged
Conversation
…ontract SQL away from MySQL
jschoedl
force-pushed
the
mysql-rules-duckdb-dialect
branch
from
September 25, 2026 12:20
ab31a5b to
cd0dbb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL quality rules on
mysqlandicebergservers are now parsed by the read-only SQL guard as DuckDB SQL, which is what actually runs them. That closes a parser-differential smuggling hole. On the mysql path, the attached MySQL catalog is DETACHed once tables are copied, and untrusted contracts getrestrict_to_paths(con, []). Double-quotes in table names are escaped to prevent SQL injection throughphysicalName.Fixes:
physicalNameduckdb_databases()