feat: lead What AI visitors do with an exact all-AI summary - #982
Conversation
…I against everyone
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
The latest updates on your projects. Learn more about Unkey Deploy
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| previous={baseline.pages_per_visit} | ||
| /> | ||
| </div> | ||
| <p className="mt-1 text-muted-foreground text-xs"> |
There was a problem hiding this comment.
Missing required typography classes The new engagement paragraph shows percentages without
text-pretty or tabular-nums. The repository’s UI guidelines require text-pretty for paragraphs and tabular-nums for data. The new pages-per-visit and fallback paragraphs also lack text-pretty. Please satisfy this repository requirement before merging.
Context Used: .cursor/rules/ui-guidelines.mdc (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| GROUP BY GROUPING SETS ((ai_product), ()) | ||
| HAVING ai_product != '' OR grouping(ai_product) = 1 | ||
| ORDER BY grouping(ai_product) DESC, visitors DESC | ||
| GROUP BY GROUPING SETS ((ai_product), (is_ai), ()) |
There was a problem hiding this comment.
Combined visitor behavior lacks coverage The new grouping set promises an exact “All AI visitors” count, but the builder compile checks do not verify that a visitor appearing under multiple AI products is counted only once or that the combined row stays distinct from “All visitors.” A focused test with overlapping products would catch regressions in the main behavior this change adds.
Cherry-picked from staging.
ai_visitor_outcomesadds an "All AI visitors" row: visits from any AI product, each visit counted once (a grouping set, not a sum of products). On prod it equals the sum of products where visitors don't overlap: databuddy.cc 31 (26+3+2), opencut.app 15 (11+2+1+1). No other code reads this builder.Tested: builder compile suite 356, types, lint, policies; query checked on prod read-only.
Summary by cubic
Adds an "All AI visitors" summary row to "What AI visitors do" and leads the panel with an AI-vs-all headline. Cherry-picked from staging.
is_aigrouping set so the row counts each visit once, not as a sum of per-product rows.Written for commit 2ba0b4a. Summary will update on new commits.