Skip to content

feat: lead What AI visitors do with an exact all-AI summary - #982

Merged
izadoesdev merged 3 commits into
mainfrom
izadoesdev/ai-visitors-summary-release
Sep 28, 2026
Merged

izadoesdev merged 3 commits into
mainfrom
izadoesdev/ai-visitors-summary-release

Conversation

@izadoesdev

@izadoesdev izadoesdev commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Cherry-picked from staging.

  • ai_visitor_outcomes adds an "All AI visitors" row: visits from any AI product, each visit counted once (a grouping set, not a sum of products). On prod it equals the sum of products where visitors don't overlap: databuddy.cc 31 (26+3+2), opencut.app 15 (11+2+1+1). No other code reads this builder.
  • "What AI visitors do" leads with pages per visit from AI against everyone and the viewed-2+-pages share against all visitors; the All AI visitors row sits above the All visitors baseline when more than one product sent visitors.

Tested: builder compile suite 356, types, lint, policies; query checked on prod read-only.


Summary by cubic

Adds an "All AI visitors" summary row to "What AI visitors do" and leads the panel with an AI-vs-all headline. Cherry-picked from staging.

  • The builder adds an is_ai grouping set so the row counts each visit once, not as a sum of per-product rows.
  • The panel opens with pages per visit from AI and the 2+ page share against all visitors, both in tabular numbers.
  • The All AI visitors row is styled like the baseline and appears only when more than one product sent visitors.
  • Tested via the builder compile suite (356), types, lint, policies, and a prod read-only query check.

Written for commit 2ba0b4a. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dashboard Ready Ready Preview Sep 28, 2026 8:10pm UTC
databuddy-status Ready Ready Preview Sep 28, 2026 8:10pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
documentation Skipped Skipped Sep 28, 2026 8:10pm UTC

@unkey-deploy

unkey-deploy Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Unkey Deploy

Name Status Preview Inspect Updated (UTC)
links (preview) Ready Visit Preview Inspect Sep 28, 2026 8:10pm

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1b411586-a8cf-4d72-8cab-9dc679646415

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium risk] Adds a new summary row to the AI visitors analytics query.

The behavior appears safe to merge, but the explicit dashboard typography requirement should be satisfied first.

Findings

  1. P2 Missing required typography classes ▶
  2. P2 Combined visitor behavior lacks coverage ▶

Summary

The PR adds a distinct “All AI visitors” aggregate to the visitor-outcomes query and uses it to lead the dashboard panel with AI-versus-all-visitor engagement metrics.

  • Product rows remain separate from the combined AI and all-visitor baselines.
  • The new presentation needs typography-rule compliance, and the grouping-set behavior would benefit from a focused regression test.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  E[Visitor events] --> S[Visits with AI product and pageviews]
  S --> G[Grouping sets]
  G --> P[Per-product rows]
  G --> A[All AI visitors]
  G --> B[All visitors]
  A --> H[Dashboard headline]
  B --> H
  P --> T[Outcomes table]
  A --> T
  B --> T
Loading

Reviews (1) · Last reviewed commit: "feat(dashboard): lead What AI visitors d..."

previous={baseline.pages_per_visit}
/>
</div>
<p className="mt-1 text-muted-foreground text-xs">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing required typography classes The new engagement paragraph shows percentages without text-pretty or tabular-nums. The repository’s UI guidelines require text-pretty for paragraphs and tabular-nums for data. The new pages-per-visit and fallback paragraphs also lack text-pretty. Please satisfy this repository requirement before merging.

Context Used: .cursor/rules/ui-guidelines.mdc (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

GROUP BY GROUPING SETS ((ai_product), ())
HAVING ai_product != '' OR grouping(ai_product) = 1
ORDER BY grouping(ai_product) DESC, visitors DESC
GROUP BY GROUPING SETS ((ai_product), (is_ai), ())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Combined visitor behavior lacks coverage The new grouping set promises an exact “All AI visitors” count, but the builder compile checks do not verify that a visitor appearing under multiple AI products is counted only once or that the combined row stays distinct from “All visitors.” A focused test with overlapping products would catch regressions in the main behavior this change adds.

@vercel
vercel Bot temporarily deployed to Preview – documentation September 28, 2026 20:10 Inactive
@izadoesdev
izadoesdev merged commit 440c3a3 into main Sep 28, 2026
23 checks passed
@izadoesdev
izadoesdev deleted the izadoesdev/ai-visitors-summary-release branch September 28, 2026 20:18

This branch was successfully deployed

3 active and 1 inactive deployments
Preview – dashboard — 2ba0b4af Deployed Sep 28, 2026 by vercel[bot]
Preview – databuddy-status — 2ba0b4af Deployed Sep 28, 2026 by vercel[bot]
links - preview — 2ba0b4af Deployed Sep 28, 2026 by unkey-deploy[bot]
Preview – documentation — 2ba0b4af Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant