Skip to content

Fix CI and release container publishing#2127

Open
SharonHart wants to merge 8 commits into
mainfrom
shhart-microsoft-analyze-analyzer-release
Open

Fix CI and release container publishing#2127
SharonHart wants to merge 8 commits into
mainfrom
shhart-microsoft-analyze-analyzer-release

Conversation

@SharonHart

@SharonHart SharonHart commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • run release container builds through a shared image/platform matrix for all three images, using native amd64 and arm64 runners
  • create release multi-platform manifests for all images after platform-specific pushes complete
  • keep main-branch CI E2E tests on ephemeral images by saving build outputs as short-lived workflow artifacts and loading them in the E2E jobs instead of publishing gha* tags to GHCR
  • keep non-main CI using local Docker Compose build+E2E without publishing

Validation

  • parsed updated workflow YAML
  • checked workflow diffs for whitespace issues
  • validated Docker Compose config with CI image environment

Build analyzer release images on native platform runners and create manifests afterward. Stop CI from publishing ephemeral gha images by building and testing Docker images locally in the same job.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 28, 2026 18:42
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report (presidio-anonymizer)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  presidio-anonymizer/presidio_anonymizer
  anonymizer_engine.py
  presidio-anonymizer/presidio_anonymizer/operators
  custom.py
Project Total  

This report was generated by python-coverage-comment-action

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report (presidio-cli)

This PR does not seem to contain any modification to coverable code.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report (presidio-structured)

This PR does not seem to contain any modification to coverable code.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions CI and release workflows to change how Docker images are built/tested and how release images are published to GHCR, with the goal of preventing CI from pushing ephemeral gha* tags while still producing correct multi-arch release images.

Changes:

  • CI: remove the main-branch “build + push platform images + create manifests + GHCR-pull E2E” pipeline and replace it with local docker compose build + E2E tests (no image publishing).
  • Release: stop building presidio-analyzer via the existing multi-platform build path; instead build/push per-platform analyzer images on native runners and then create multi-arch manifests.
  • Release: keep presidio-anonymizer and presidio-image-redactor on the existing multi-platform build/push flow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yml Splits analyzer release builds into native per-arch image pushes plus a manifest creation job; keeps anonymizer/image-redactor on the existing multi-arch build flow.
.github/workflows/ci.yml Removes CI jobs that pushed ephemeral images/manifests to GHCR; runs E2E against locally-built Compose images on amd64 and arm64 runners.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report (presidio-image-redactor)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  presidio-image-redactor/presidio_image_redactor
  dicom_image_pii_verify_engine.py
  document_intelligence_ocr.py
  image_analyzer_engine.py
Project Total  

This report was generated by python-coverage-comment-action

Run release container builds through a shared image/platform matrix on native runners before creating manifests. Keep CI image builds as ephemeral artifacts that E2E jobs download and load instead of publishing gha tags to GHCR.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report (presidio-analyzer)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  presidio-analyzer/presidio_analyzer
  analyzer_engine.py
  entity_recognizer.py
  presidio-analyzer/presidio_analyzer/input_validation
  schemas.py
  yaml_recognizer_models.py
  presidio-analyzer/presidio_analyzer/nlp_engine
  __init__.py
  nlp_engine_provider.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers
  __init__.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/country_specific
  __init__.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/country_specific/australia
  au_abn_recognizer.py
  au_acn_recognizer.py
  au_medicare_recognizer.py
  au_tfn_recognizer.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/country_specific/finland
  fi_personal_identity_code_recognizer.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/country_specific/germany
  de_bsnr_recognizer.py
  de_fuehrerschein_recognizer.py
  de_id_card_recognizer.py
  de_lanr_recognizer.py
  de_passport_recognizer.py
  de_social_security_recognizer.py
  de_tax_id_recognizer.py
  de_vat_id_recognizer.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/country_specific/poland
  pl_pesel_recognizer.py
  presidio-analyzer/presidio_analyzer/predefined_recognizers/generic
  phone_recognizer.py
  presidio-analyzer/presidio_analyzer/recognizer_registry
  recognizer_registry.py
  recognizers_loader_utils.py
Project Total  

The report is truncated to 25 files out of 69. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml Outdated
@SharonHart SharonHart requested a review from omri374 June 28, 2026 19:14
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 28, 2026 19:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/release.yml Outdated
Comment on lines +177 to +178
for image in presidio-anonymizer presidio-analyzer presidio-image-redactor; do
repo="${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAMESPACE }}/${image}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 63f3925.

Comment thread .github/workflows/release.yml Outdated
Comment on lines +185 to +189
for tag in latest "${version_tag}"; do
docker buildx imagetools create \
--tag ${repo}:${tag} \
${repo}:${tag}-linux-amd64 \
${repo}:${tag}-linux-arm64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in d9ab440.

Copilot AI review requested due to automatic review settings June 28, 2026 19:22
@SharonHart SharonHart removed the request for review from Copilot June 28, 2026 19:22
omri374
omri374 previously approved these changes Jun 28, 2026
Copilot AI review requested due to automatic review settings June 28, 2026 19:30
@SharonHart SharonHart removed the request for review from Copilot June 28, 2026 19:30
Copilot AI review requested due to automatic review settings June 28, 2026 19:31
@SharonHart SharonHart removed the request for review from Copilot June 28, 2026 19:31
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 28, 2026 19:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants