Fix URL test bounds for DPS domain#2125
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Coverage report (presidio-anonymizer)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the URL recognizer unit tests to correct the expected end index for quoted URLs using the presidio.dataprivacystack.org domain, ensuring the asserted match span includes both the opening and closing quote characters.
Changes:
- Fix expected match bounds for double-quoted and single-quoted
https://presidio.dataprivacystack.org/test cases from(0, 39)to(0, 40).
Contributor
Coverage report (presidio-cli)
This PR does not seem to contain any modification to coverable code. |
Contributor
Coverage report (presidio-structured)
This PR does not seem to contain any modification to coverable code. |
Contributor
Coverage report (presidio-image-redactor)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
omri374
approved these changes
Jun 28, 2026
Contributor
Coverage report (presidio-analyzer)
Click to see where and how coverage changed
The report is truncated to 25 files out of 69. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the URL entity test cases in
presidio-analyzer/tests/test_url_recognizer.pyto correct the expected span of quoted URLs.