Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…d with private agents Upgrade lib-node 2.15 whose default agents refuse non public addresses: plugin requests through context.axios are guarded, data-fair and registry requests use the private agents. The data-fair url is matched by origin and base path instead of a string prefix that sent the api key to lookalike hosts, and data-fair requests do not follow redirections. Dev environments must allow the loopback with SSRF_PUBLIC_IPS. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
# Conflicts: # api/package.json # package-lock.json
simple-directory added a show-password button whose label also matches. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
# Conflicts: # api/package.json # package-lock.json # package.json # shared/package.json # worker/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade lib-node 2.15 / lib-express 1.28.1 / lib-node-registry 0.7.2, whose default HTTP agents refuse non public addresses: plugin requests through
context.axiosare now protected. Requests to data-fair and to the registry use the private agents. The data-fair URL is matched by origin and base path instead of a string prefix (it decides which requests receive the data-fair API key), and data-fair requests no longer follow redirections. Mails sent by plugins can no longer read local files or fetch URLs.Why: processing configurations and remote content choose the URLs plugins request; they must not reach our infrastructure or receive our credentials.
Heads-up: instances whose plugins fetch intranet sources must declare them in
SSRF_PUBLIC_IPS; dev environments needSSRF_PUBLIC_IPS=127.0.0.1,::1(added todev/init-env.sh). Data-fair now only accepts the processings admin API key on internal calls: setPRIVATE_DATA_FAIR_URL.