Repository navigation
TST: skip test_matmul on NumPy 1.22 because @= fails - #487
Merged
Merged
Conversation
Since data-apis/array-api-tests#466 `test_linalg::test_matmul` exercises the in-place matmul operator, `@=`. This is expected by the spec, but is not implemented in numpy 1.22. Since this was since implemented between 1.22 and 1.26, just skip the test under `numpy==1.22`.
Member
Author
|
dpnp CI failures are unrelated, am going to merge in the in-place matmul skip straight away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since data-apis/array-api-tests#466
test_linalg::test_matmulexercises the in-place matmul operator,@=. This is expected by the spec, but is not implemented in numpy 1.22.Since this was since implemented between 1.22 and 1.26, just skip the test under
numpy==1.22.