Skip to content

build(deps): bump actions/upload-pages-artifact from 4 to 5#195

Merged
lklimek merged 1 commit into
developfrom
dependabot/github_actions/actions/upload-pages-artifact-5
Apr 24, 2026
Merged

build(deps): bump actions/upload-pages-artifact from 4 to 5#195
lklimek merged 1 commit into
developfrom
dependabot/github_actions/actions/upload-pages-artifact-5

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Apr 14, 2026

Copy link
Copy Markdown
Contributor

Bumps actions/upload-pages-artifact from 4 to 5.

Release notes

Sourced from actions/upload-pages-artifact's releases.

v5.0.0

Changelog

See details of all code changes since previous release.

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Apr 14, 2026
@Claudius-Maginificent

Copy link
Copy Markdown

Security Review — actions/upload-pages-artifact v4 → v5

Verdict: SAFE to merge. Recommend approval once CI clears.

Standing orders say trust nothing, verify twice. So I did.

What changed

Single-line bump in .github/workflows/github-pages.yml (line 48). Build-time CI action only — publishes rustdoc to GitHub Pages. No runtime code path, no production surface.

Supply-chain verification

  • Publisher: actions/ org — first-party GitHub. High trust.
  • Tag integrity: v5 and v5.0.0 both resolve to commit fc324d3547104276b827a68afc52ff2a11cc49c9. Commit signature verified by GitHub. Authored by tsusdere@github.com (Fabian), committed 2026-04-08.
  • Nested pin: upload-pages-artifact v5 pins its internal actions/upload-artifact@v7 dependency to a SHA (see PR build(deps): bump docker/build-push-action from 6.15.0 to 6.16.0 #139 in the upstream repo). No floating reference downstream.
  • CVE search: OSV.dev, NVD, GHSA — no known vulnerabilities for actions/upload-pages-artifact (any version) or the wrapped actions/upload-artifact@v7.

v5.0.0 changes reviewed

  1. Bumps wrapped actions/upload-artifact from v6 to v7 (Node 24 runtime — supported on ubuntu-latest).
  2. Adds include-hidden-files input, defaults to false — matches prior v4 behaviour. No change for us.

Breaking-change impact on our usage

Our call site passes only path: "target/doc". The path input default is unchanged (_site/). We do not rely on dotfiles being packaged; rustdoc output under target/doc needs no .nojekyll because the pages pipeline serves the tar artifact via actions/deploy-pages@v4 rather than through Jekyll. Companion actions (actions/configure-pages@v5, actions/deploy-pages@v4) remain on versions compatible with upload-pages-artifact v5.

No behavioural regression expected.

Notes

  • CI red is pre-existing (fmt + test-all), unrelated to this bump; expected to clear after rebase once build(deps): update zip requirement from 7.0 to 8.5 #193 merges.
  • I verified the v5 tag points to the same SHA documented in the dependabot PR body. Consistent. No tag-moving shenanigans.

🍬 Findings this run: 0 vulnerabilities, 1 clean supply-chain chain-of-custody verified.

Carry on.

🤖 Co-authored by Claudius the Magnificent AI Agent

@lklimek

lklimek commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

@dependabot rebase

Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-pages-artifact/releases)
- [Commits](actions/upload-pages-artifact@v4...v5)

---
updated-dependencies:
- dependency-name: actions/upload-pages-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/github_actions/actions/upload-pages-artifact-5 branch from 6c79df8 to 43eb9e6 Compare April 24, 2026 08:38
@lklimek
lklimek merged commit fd3751d into develop Apr 24, 2026
9 of 10 checks passed
@lklimek
lklimek deleted the dependabot/github_actions/actions/upload-pages-artifact-5 branch April 24, 2026 08:43
@lklimek lklimek mentioned this pull request Apr 24, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants