Skip to content

fix(query): apply terminal-key conditionals per item#734

Open
QuantumExplorer wants to merge 2 commits into
developfrom
codex/fix-689-terminal-keys-conditionals
Open

fix(query): apply terminal-key conditionals per item#734
QuantumExplorer wants to merge 2 commits into
developfrom
codex/fix-689-terminal-keys-conditionals

Conversation

@QuantumExplorer

Copy link
Copy Markdown
Member

Summary

  • compute terminal keys by iterating queried items before applying conditional branches
  • preserve first-matching conditional semantics and fall back to the default branch when no condition matches
  • add terminal-key regressions plus an absence-proof verification case for unqueried conditional branches

Fixes #689.

Verification

  • cargo test -p grovedb-query terminal_keys --test query_terminal_and_merge
  • cargo test -p grovedb conditional_subquery_branches --lib
  • cargo test -p grovedb verify_absence_ignores_unqueried_conditional_subquery_branches --lib
  • git diff --check

@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@QuantumExplorer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 19 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5f5fa02d-b27d-48cf-bc49-1d0ee7a07923

📥 Commits

Reviewing files that changed from the base of the PR and between a2129a9 and 503d3b8.

📒 Files selected for processing (5)
  • grovedb-query/src/query.rs
  • grovedb-query/tests/query_terminal_and_merge.rs
  • grovedb-version/src/version/v3.rs
  • grovedb/src/query/mod.rs
  • grovedb/src/tests/proof_coverage_tests.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-689-terminal-keys-conditionals

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.26027% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.42%. Comparing base (60f2968) to head (503d3b8).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
grovedb-query/src/query.rs 97.67% 3 Missing ⚠️
grovedb/src/query/mod.rs 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #734      +/-   ##
===========================================
- Coverage    91.42%   91.42%   -0.01%     
===========================================
  Files          236      236              
  Lines        67053    67248     +195     
===========================================
+ Hits         61305    61481     +176     
- Misses        5748     5767      +19     
Components Coverage Δ
grovedb-core 88.96% <94.11%> (+0.02%) ⬆️
merk 92.26% <ø> (ø)
storage 86.36% <ø> (ø)
commitment-tree 96.43% <ø> (ø)
mmr 96.79% <ø> (+0.03%) ⬆️
bulk-append-tree 89.39% <ø> (+0.13%) ⬆️
element 97.38% <ø> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@QuantumExplorer QuantumExplorer changed the title Apply terminal-key conditionals per queried item fix(query): apply terminal-key conditionals per item May 21, 2026
@QuantumExplorer QuantumExplorer force-pushed the codex/fix-689-terminal-keys-conditionals branch from 99a27f5 to cc83d0f Compare May 21, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[audit][medium] terminal_keys resolves conditional branches differently from query execution

1 participant