Skip to content

feat(ui): redesign About Dash screen#780

Open
romchornyi wants to merge 2 commits into
masterfrom
feat/redesign-about-dash
Open

feat(ui): redesign About Dash screen#780
romchornyi wants to merge 2 commits into
masterfrom
feat/redesign-about-dash

Conversation

@romchornyi

@romchornyi romchornyi commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

This PR redesigns the About Dash screen in Settings to provide a cleaner and more polished presentation of Dash-related information and links.

It improves the existing experience by replacing the older layout with a more structured SwiftUI-based screen, refreshed visuals, and clearer navigation entry points.

What was done?

  • Redesigned the About Dash screen UI in Settings.
  • Added a dedicated AboutDashViewModel to structure the screen content and presentation logic.
  • Updated AboutDashView to use the new layout and content organization.
  • Integrated the redesigned screen into SettingsScreen.
  • Added new supporting assets for the About Dash experience.

How Has This Been Tested?

  • Performed a self-review of the implemented changes.
  • Verified that the new screen files, assets, and project references are included in the staged diff as expected.
  • Confirmed the project version/build settings were updated consistently in the project file.
  • Full build/runtime validation was not completed in this environment before preparing the PR.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • New Features

    • Added a new About Dash settings screen displaying app version, DashSync version, explore sync status, and device synchronization timestamps.
    • Users can now request an App Store review directly from the About screen.
    • Added contact support functionality allowing users to send support emails from the app.
  • Chores

    • Added new image assets for app branding and UI elements.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@romchornyi, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 minutes and 35 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a598ab19-80d7-4a3f-8961-7cd9c7401623

📥 Commits

Reviewing files that changed from the base of the PR and between 155692d and 2bd2275.

📒 Files selected for processing (1)
  • DashWallet/Sources/UI/Menu/Settings/About/AboutDashView.swift
📝 Walkthrough

Walkthrough

Replaces the legacy DWAboutViewController with a new SwiftUI AboutDashView backed by AboutDashViewModel. The view model publishes version strings, ExploreDash sync status, and device sync timestamps, and exposes an App Store review action. Three image asset sets are added, and SettingsScreen is updated to push a UIHostingController-based wrapper that handles navigation and mail compose presentation.

Changes

About Dash SwiftUI Screen

Layer / File(s) Summary
Image asset catalog additions
DashWallet/Resources/AppAssets.xcassets/app-review.imageset/Contents.json, DashWallet/Resources/AppAssets.xcassets/logo.imageset/Contents.json, DashWallet/Resources/AppAssets.xcassets/support.imageset/Contents.json
Three new image sets (app-review, logo, support) added to the asset catalog, each defining 1x/2x/3x universal PNG renditions.
AboutDashViewModel: published state, lifecycle, and actions
DashWallet/Sources/UI/Menu/Settings/About/AboutDashViewModel.swift
AboutDashViewModel declares @Published properties for app/DashSync version, explore sync status, and sync timestamps. init builds version strings from the bundle and DashSyncCurrentCommit resource, loads ExploreDash state, and registers for database-update notifications. reviewApp() calls SKStoreReviewController.requestReview(in:). reloadExploreState() maps ExploreDash.shared.syncState to localized strings and formats dates. Preview helpers apply hardcoded sample data.
AboutDashView SwiftUI layout
DashWallet/Sources/UI/Menu/Settings/About/AboutDashView.swift
Defines the full AboutDashView body: navigation back button, version/status list sections, review app and contact support action rows, a localized footer with a conditional repository Link, and a #Preview entry.
SettingsScreen navigation wiring
DashWallet/Sources/UI/Menu/Settings/SettingsScreen.swift
showAboutController() now pushes AboutDashHostingViewController instead of DWAboutViewController. The new AboutDashHostingViewController embeds AboutDashView in a UIHostingController, hides the navigation bar, wires onBack to pop the stack, wires onContactSupport to present MFMailComposeViewController, and implements MFMailComposeViewControllerDelegate to dismiss the composer on completion.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐇 Hippity-hop, the "About" page is new,
SwiftUI pixels in every hue!
The version strings gleam, the sync dates align,
A logo, a star, and a support sunshine.
Old UIKit farewell — SwiftUI's the way,
This bunny ships features each bright hoppy day! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat(ui): redesign About Dash screen' directly and clearly summarizes the main objective of the pull request, which is a UI redesign of the About Dash screen as confirmed by the PR objectives and file changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/redesign-about-dash

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@DashWallet/Sources/UI/Menu/Settings/About/AboutDashView.swift`:
- Around line 33-98: The AboutDashView content is not scrollable, causing the
lower sections including menu items and footer text to be clipped on small
screens or with larger text sizes. Wrap the main content VStack (the one with
alignment .leading and spacing 20 that contains appVersion, dashSyncVersion,
exploreStatus, and other menu items) in a ScrollView to enable scrolling on
compact devices. Keep the NavigationBar outside the ScrollView at the top so it
remains visible, and remove or adjust the Spacer() after the ScrollView since it
will no longer be needed for layout purposes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aa0fabdb-0128-445d-9a14-b0c103a55bcc

📥 Commits

Reviewing files that changed from the base of the PR and between fa5e4af and 155692d.

⛔ Files ignored due to path filters (9)
  • DashWallet/Resources/AppAssets.xcassets/app-review.imageset/app-review.png is excluded by !**/*.png
  • DashWallet/Resources/AppAssets.xcassets/app-review.imageset/app-review@2x.png is excluded by !**/*.png
  • DashWallet/Resources/AppAssets.xcassets/app-review.imageset/app-review@3x.png is excluded by !**/*.png
  • DashWallet/Resources/AppAssets.xcassets/logo.imageset/logo.png is excluded by !**/*.png
  • DashWallet/Resources/AppAssets.xcassets/logo.imageset/logo@2x.png is excluded by !**/*.png
  • DashWallet/Resources/AppAssets.xcassets/logo.imageset/logo@3x.png is excluded by !**/*.png
  • DashWallet/Resources/AppAssets.xcassets/support.imageset/support.png is excluded by !**/*.png
  • DashWallet/Resources/AppAssets.xcassets/support.imageset/support@2x.png is excluded by !**/*.png
  • DashWallet/Resources/AppAssets.xcassets/support.imageset/support@3x.png is excluded by !**/*.png
📒 Files selected for processing (7)
  • DashWallet.xcodeproj/project.pbxproj
  • DashWallet/Resources/AppAssets.xcassets/app-review.imageset/Contents.json
  • DashWallet/Resources/AppAssets.xcassets/logo.imageset/Contents.json
  • DashWallet/Resources/AppAssets.xcassets/support.imageset/Contents.json
  • DashWallet/Sources/UI/Menu/Settings/About/AboutDashView.swift
  • DashWallet/Sources/UI/Menu/Settings/About/AboutDashViewModel.swift
  • DashWallet/Sources/UI/Menu/Settings/SettingsScreen.swift

Comment thread DashWallet/Sources/UI/Menu/Settings/About/AboutDashView.swift

@HashEngineering HashEngineering left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is DWAboutViewController a class and set of files that is still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants