feat(wallet): CrowdNode show balance message#779
Conversation
|
Warning Review limit reached
More reviews will be available in 38 minutes and 4 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds a CrowdNode Balance Reminder feature: a new ChangesCrowdNode Balance Reminder Feature
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@DashWallet/Sources/UI/CrowdNode/BalanceReminder/CrowdNodeWithdrawalRouter.swift`:
- Around line 93-100: The mainAction closure in the CrowdNodeWithdrawalRouter
captures navigationController strongly, creating a retain cycle since
navigationController owns the controller that contains this closure. Modify the
closure definition to use weak capture for navigationController by adding a
capture list at the beginning of the closure (after the opening brace), and then
safely unwrap navigationController before using it in the pushViewController
call to ensure it remains valid and the reference cycle is broken.
In `@DashWallet/Sources/UI/Home/HomeViewController.swift`:
- Around line 529-535: Replace the force unwrap of invitationSetup.invitation in
the handleDeeplink call within the DASHPAY conditional block of
HomeViewController with a safe guard let statement. Instead of using
invitation!, use guard let to safely unwrap the invitation property and only
proceed with the handleDeeplink call if the invitation is present, otherwise
skip the operation.
In `@DashWallet/Sources/UI/SwiftUI` Components/SelfSizingSheet.swift:
- Around line 50-54: Remove the debug print statement in the detents computed
property of the SelfSizingSheet class. The line `print("\(height)")` executes in
production builds and should not be included unless wrapped in a `#if DEBUG`
block. Since this appears to be a temporary debug statement, delete this line
entirely to clean up the code.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 35da2df1-9355-427f-b913-b1e7489dd9cb
📒 Files selected for processing (8)
DashWallet.xcodeproj/project.pbxprojDashWallet/Sources/Models/CrowdNode/CrowdNodeBalanceReminder.swiftDashWallet/Sources/UI/CrowdNode/BalanceReminder/CrowdNodeBalanceReminderBanner.swiftDashWallet/Sources/UI/CrowdNode/BalanceReminder/CrowdNodeBalanceReminderSheet.swiftDashWallet/Sources/UI/CrowdNode/BalanceReminder/CrowdNodeWithdrawalRouter.swiftDashWallet/Sources/UI/Explore Dash/ExploreMenuScreen.swiftDashWallet/Sources/UI/Home/HomeViewController.swiftDashWallet/Sources/UI/SwiftUI Components/SelfSizingSheet.swift
2 participants
Issue being fixed or feature implemented
This PR adds a CrowdNode balance reminder flow for users who still have funds associated with CrowdNode.
It solves the missing visibility around remaining CrowdNode balances by surfacing a reminder on the active Home flow and in Explore, and by giving users a direct path into the withdrawal flow.
What was done?
How Has This Been Tested?
Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
Release Notes