backport: keep PoSe score visible when hiding banned masternodes#7445
Closed
thepastaclaw wants to merge 1 commit into
Closed
backport: keep PoSe score visible when hiding banned masternodes#7445thepastaclaw wants to merge 1 commit into
thepastaclaw wants to merge 1 commit into
Conversation
Member
|
Closing; I've added the backport label to the other PR, so it'll be included in next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The Hide banned checkbox on the Masternodes tab filters PoSe-banned
masternodes, but v23.1.x also hides the entire PoSe Score column. This prevents
users from seeing residual PoSe penalties on masternodes that are not yet
banned.
This was reported in #7286 and fixed on
developby#7298. The fix has not reached the v23.1.x release branch.
What was done?
Backport the merged one-line fix from #7298. The checkbox continues
to filter banned rows through
MasternodeListSortFilterProxyModel, while thePoSe Score column remains visible.
How Has This Been Tested?
checkbox is selected.
model after removing the column-visibility call.
git diff --checkshipA full GUI build was not run locally; GitHub CI will provide the branch build
coverage.
Breaking Changes
None.
Checklist: