Skip to content

Build 11.8.1#1491

Merged
HashEngineering merged 2 commits into
masterfrom
build-11.8.1
Jun 14, 2026
Merged

Build 11.8.1#1491
HashEngineering merged 2 commits into
masterfrom
build-11.8.1

Conversation

@HashEngineering

@HashEngineering HashEngineering commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

Summary by CodeRabbit

  • Bug Fixes

    • CrowdNode functionality restricted to withdrawals only
    • Deposits and account linking temporarily unavailable
    • Online account button hidden across all account states
  • New Features

    • DashSpend gift card quantity enhancements
    • Maya swap integration support
    • Redesigned tools menu and improved CSV export
  • Chores

    • Version bumped to 11.8.1

@HashEngineering HashEngineering self-assigned this Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0af492d5-af53-4ec8-b7a5-89ccfd38d48a

📥 Commits

Reviewing files that changed from the base of the PR and between ccfd04a and e908b37.

📒 Files selected for processing (4)
  • integrations/crowdnode/CLAUDE.md
  • integrations/crowdnode/src/main/java/org/dash/wallet/integrations/crowdnode/ui/portal/PortalFragment.kt
  • wallet/CHANGES
  • wallet/build.gradle

📝 Walkthrough

Walkthrough

This PR restricts CrowdNode functionality to withdrawals only by unconditionally hiding the online account button in the Portal UI. The code change in PortalFragment, documentation updates explaining the restriction and historical crash context, and release notes for v11.8.1 are included alongside build version bumps.

Changes

CrowdNode Withdrawals-Only Restriction

Layer / File(s) Summary
Online account button visibility restriction
integrations/crowdnode/src/main/java/org/dash/wallet/integrations/crowdnode/ui/portal/PortalFragment.kt, integrations/crowdnode/CLAUDE.md
PortalFragment's setOnlineAccountStatus method now unconditionally hides binding.onlineAccountBtn for all OnlineAccountStatus values. CLAUDE.md clarifies that deposits, account linking, and the online account button are hidden from the UI while withdrawals remain enabled, expands the Portal flow description with a historical note explaining that earlier Done-only visibility caused a primaryDashAddress!! null crash, and adjusts undo instructions to warn against restoring that prior visibility logic.
Release version updates and changelog
wallet/CHANGES, wallet/build.gradle
Release notes for v11.8.1 and v11.8.0 are prepended to wallet/CHANGES, documenting the CrowdNode withdrawals-only restriction and other features/fixes. Build.gradle version defaults are bumped to versionCode 11080101 and versionName "11.8.1".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • dashpay/dash-wallet#1490: Main PR's change to unconditionally hide the online-account button aligns with PR #1490's broader "disable CrowdNode except withdraw" UI gating, which includes related PortalFragment visibility changes.

Suggested reviewers

  • abaranouski

Poem

🐰 A button once visible for all,
Now hidden to heed the withdrawal call,
CrowdNode bows to withdrawals alone,
With docs that explain the crash we have known,
Version bumped up, the release is done! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Build 11.8.1' is clearly related to the changeset, which includes version bumps in build.gradle, changelog updates, and supporting code changes that align with preparing a 11.8.1 release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build-11.8.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@abaranouski abaranouski left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested manually

@HashEngineering HashEngineering merged commit a141bc3 into master Jun 14, 2026
3 checks passed
@HashEngineering HashEngineering deleted the build-11.8.1 branch June 14, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants