feat(workloads): don't instrument workloads w. low storage limits#1014
Merged
basti1302 merged 1 commit intoMay 18, 2026
Merged
Conversation
Member
Author
|
/run-e2e |
Contributor
🚀 E2E tests triggered
Results will be posted here once the tests complete. You can also view the workflow runs directly. |
Contributor
✅ E2E tests passed
|
p-d0
approved these changes
May 8, 2026
Member
Author
|
I think I'd like to merge this one after #1009 actually, and then only reject instrumenting a container with low storage limits if the instrumentation delivery is != image volume. |
Member
Author
Added a blocked label to make it more obvious that this one is currently on hold. |
Adding the dash0-instrumentation emptyDir volume to workloads with tight ephemeral storage limits will cause pod eviction. This check is only applied for instrumentation delivery method init-container, not for image-volume delivery.
basti1302
force-pushed
the
ope-331-detect-ephemeral-storage-limit-do-not-instrument-with
branch
from
745c969 to
b6626f6
Compare
|
basti1302
deleted the
ope-331-detect-ephemeral-storage-limit-do-not-instrument-with
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the dash0-instrumentation volume to workloads with tight ephemeral storage limits will cause pod eviction.