VIM Visual Mode#80
Conversation
Committing review suggestion. Co-authored-by: Har Jing Daryl <53652695+darylhjd@users.noreply.github.com>
Accepting review suggestion Co-authored-by: Har Jing Daryl <53652695+darylhjd@users.noreply.github.com>
|
Oh whoops, sorry, I'm a bit of a github newbie too. I think this diff also includes the commits from the guest mode pr. Is this fine and just gets resolved whenever the other pr is merged? Still sad that the diff from the guest feature shows up in your review though. Will be moving this pr to a draft in the meantime. |
|
You will likely need to rebase once I merge your other PR to the main branch. |
|
Sorry for the inaction regarding this PR, have been busy. Seems like this branch is currently not rebased on main. I will do that and review it soon. Thanks! |
|
Please add new keybindings to the README. |
Applying suggested change. Co-authored-by: Har Jing Daryl <53652695+darylhjd@users.noreply.github.com>
No worries! Thanks for reviewing! Thanks for rebasing too!
Added! Lmk if reasonable wording! I've also included your changes and re-manually tested by building + running and testing that selecting in visual mode still works manually. Thanks! |
|
im not too familiar with visual mode on VIM, so i am not sure what it does and how the behaviour translates to mangadesk. i guess it works something like text selection, just that it works with rows here. do correct me if im wrong. from my testing, it works well, but there are a few quirks:
|
| return event | ||
| }) | ||
|
|
||
| p.Table.SetSelectionChangedFunc(func(row, _column int) { |
There was a problem hiding this comment.
A comment on what this binding does would be useful. See line 182 of same file for example.
| p.markAll() | ||
| } | ||
|
|
||
| func (p *MangaPage) selectRange(from, to int) { |
There was a problem hiding this comment.
comment for this function and the one below would also be great.
2 participants
Addresses #79
Pressing Shift+V or v in the manga page will toggle something similar to vim's visual mode. (It's not fully 1:1 with vim's visual mode as you can't select things horizontally).
This lets you select a range of manga easily + it has the side effect of letting you select all manga chapters with
ggvG.Testing
Manual testing by runnging
go buildand then./mangadesk.