Skip to content

fix: auto-install installer deps on Windows#312

Open
zhao0112 wants to merge 1 commit into
darrenhinde:mainfrom
zhao0112:feat/windows-jq-dependency-helper
Open

fix: auto-install installer deps on Windows#312
zhao0112 wants to merge 1 commit into
darrenhinde:mainfrom
zhao0112:feat/windows-jq-dependency-helper

Conversation

@zhao0112
Copy link
Copy Markdown

Summary

This PR addresses #304 by making the installer dependency check more resilient on Windows.

Problem

On Windows (Git Bash/WSL), installations can fail early when jq (or curl) is not already installed, and users are left with a manual setup error.

Changes

  • Added install_dependency_on_windows() to attempt a best-effort dependency install for missing dependencies (curl, jq) via common Windows package managers: winget, scoop, and choco.
  • Updated check_dependencies() to:
    • collect missing dependencies,
    • attempt Windows auto-install for missing deps when possible,
    • re-check dependency availability before failing with instructions.

Closes #304

Validation

  • bash -n install.sh
  • bash install.sh list (Linux environment)
  • bash scripts/tests/test-installer-files.sh

Risks

  • On Windows without winget/scoop/choco, users still need to install missing dependencies manually.
  • The new install attempts run with best-effort behavior and proceed only after successful dependency detection; there is no hard guarantee every Windows environment has a compatible package manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Windows installation failed.

1 participant