fix(build): stamp AssemblyVersion/FileVersion 3.3.0.0#658
Merged
Conversation
Directory.Build.props pinned AssemblyVersion/FileVersion to 3.2.0.0 solution-wide. The 3.3.0 release bump (#657) updated only the csproj <Version> and the WiX Product.wxs, so the shipped 3.3.0 exe self-reported 3.2.0.0: the title bar read "DAQiFi v3.2.0" and Sentry tagged every 3.3.0 crash as release 3.2.0.0 (the assembly version drives options.Release in AppLogger). Bump the props to 3.3.0.0 so the exe, title bar, and crash telemetry match the release. The MSI ProductVersion (Product.wxs) was already correct, so install/upgrade behavior is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
PR Summary by QodoFix build version stamping to report DAQiFi 3.3.0.0
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Contributor
Code Review by Qodo
Context used✅ Compliance rules (platform):
48 rules 1.
|
The embedded Windows manifests (app.manifest, app.Debug.manifest) still declared assemblyIdentity version 3.2.0.0, leaving the embedded manifest metadata stale after the AssemblyVersion/FileVersion bump. Prior release bumps (#414, #503) updated these manifests too; match that convention so every version facet in the 3.3.0 build is consistent. The comctl32 dependentAssembly version (6.0.0.0) is unrelated and left unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Re: Qodo "Stale manifest version" finding — ✅ Fixed in 6f90343. Good catch, and correct: bumping only Bumped both manifests' top-level On the summary-level follow-up suggestion (derive these from a single version source / add a CI guard): agreed it's the right long-term direction, but out of scope for this minimal release fix — leaving it as a tracked follow-up. |
📊 Code Coverage ReportSummarySummary
CoverageDAQiFi - 43.6%
Daqifi.Desktop.Common - 40.5%
Daqifi.Desktop.IO - 100%
Coverage report generated by ReportGenerator • View full report in build artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Directory.Build.propshardcodedAssemblyVersion/FileVersionat3.2.0.0solution-wide. The 3.3.0 release bump (#657) updated only the csproj<Version>(→ informational3.3.0+sha) and the WiXProduct.wxs(→ MSI ProductVersion3.3.0.0), but missed this file — so the shipped 3.3.0 build self-reported3.2.0.0:FileVersionis3.2.0.0.release: 3.2.0.0—AppLoggersetsoptions.Release = Assembly.GetName().Version, so the stale assembly version corrupts the release tag we rely on to monitor post-release issues (notably the firmware-flash telemetry).Change
Bump
AssemblyVersion/FileVersionto3.3.0.0to match the release. One line each.After the fix, the built
DAQiFi.dllreports:The MSI
ProductVersion(fromProduct.wxs) was already correct, so install/upgrade behavior is unchanged — this only corrects the exe's self-reported version + crash telemetry.Verification
dotnet build -c Release— succeeds, assembly version confirmed3.3.0.0.Follow-up (optional, not in this PR)
Consider driving
AssemblyVersion/FileVersionfrom the csproj<Version>(single source of truth) so future release bumps only touch one place.🤖 Generated with Claude Code