Ruleset: require the private-patterns check on main - #3
Merged
Merged
Conversation
The check-run name on main's latest commit is `private-patterns` (app
github-actions), and the workflow has no paths: or if: filter, so it
reports on every PR, fork and Dependabot PRs included (they pass with a
notice on an empty secret). Ruleset 23647785 updated in place with
PUT /repos/{owner}/{repo}/rulesets/{ruleset_id}; read back as deletion,
non_fast_forward, pull_request, required_status_checks strict=true.
dependabot.yml header updated: strict checks now mean Dependabot PRs
rebase after each merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
required_status_checksto.github/rulesets/default-branch.json: one context,private-patterns, withstrict_required_status_checks_policy: true(the branch must be up to date withmainbefore merging). Nointegration_id, per the d-github reference.Why it is safe to require
gh api repos/danjonesio/deej-stack/commits/<main>/check-runslistsprivate-patterns, completed, success, appgithub-actions.pull_requestwith nopaths:orif:filter, so the check always reports; a required check that never reports would block merging forever.mainafter merge does the real check for those.Already applied
Ruleset 23647785 was updated in place (
PUT /repos/{owner}/{repo}/rulesets/{ruleset_id}, verified against docs.github.com/en/rest/repos/rules on 2026-09-18). Read back fromrules/branches/main:deletion,non_fast_forward,pull_request,required_status_checks [private-patterns] strict=true. This PR is the first one gated by it, so its merge box should showprivate-patternsas Required.Also
.github/dependabot.ymlheader: the branch-protection paragraph said there were no required checks; now says strict checks mean Dependabot PRs rebase after each merge, which is what the groups are for.Still true
The check passes with a notice and checks nothing until
~/.config/deej-stack/private-patternsexists andPRIVATE_PATTERNSis set. Requiring it now means it is already in place the day the list exists.