Skip to content

Update bulk.ex with no types#118

Closed
mrnovalles wants to merge 1 commit into
danielberkompas:masterfrom
mrnovalles:master
Closed

Update bulk.ex with no types#118
mrnovalles wants to merge 1 commit into
danielberkompas:masterfrom
mrnovalles:master

Conversation

@mrnovalles

@mrnovalles mrnovalles commented Oct 17, 2023

Copy link
Copy Markdown

ElasticSearch 7.x [1] already described the removal of mapping types. For the case of bulk endpoints:

Types should also no longer appear in the body of requests. The following example of bulk indexing omits the type both in the URL, and in the individual bulk commands:

[1] https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html

This commit removes the /_doc/ part of the URL when making Bulk uploads as part of the hot_swap_index function.

Fixes #113

@lovebes

lovebes commented Jan 19, 2024

Copy link
Copy Markdown

@danielberkompas Can we merge this in somewhat urgently? Elasticsearch is already at 8.12, and removal of /_doc imho is a change that is due. On a bit of a selfish note I need this at my job ;)

For those that need to use the current url suffix can just use the older version of :elasticsearch.

@lovebes

lovebes commented Jan 19, 2024

Copy link
Copy Markdown

Actually #106 might be a better approach I think.

@mrnovalles mrnovalles closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indexing with hot_swap or build always fails with Malformed content, found extra data after parsing: START_OBJECT

2 participants