Skip to content

Prefix the public API (functions, types and status constants) #138

Open

Description

@dance858

AI generated issue from Claude:

Follow-up to #133. The internal symbols now carry the prefix pslp_ (#137), but the public API still uses generic names, so a program that embeds PSLP can still clash with it:

  • Functions (link-time clash): postsolve, run_presolver, new_presolver, new_presolver_from_problem, free_presolver, free_presolver_reduced_problem, default_settings, free_settings, set_settings_true, set_settings_false, map_original_sol_to_reduced, postsolve_primal_infeas_ray, postsolve_dual_infeas_ray.
  • Types (compile-time clash in a file that includes PSLP_API.h): Settings, Presolver, ProblemData, Solution, PresolveStats, PresolveStatus, ConeType, ...
  • Status constants (compile-time clash): UNCHANGED, REDUCED, INFEASIBLE, UNBNDORINFEAS. INFEASIBLE in particular is a name many solvers define themselves.

Proposal: give all of them a PSLP prefix (for example pslp_postsolve, PSLPSettings, PSLP_INFEASIBLE) and keep the current names as deprecated aliases for a release or two, so that existing users are not broken at once.

This is a breaking change in the long run, so it is cheaper the earlier it is done.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions