Add tests for reflected & normal tables produce equivalent CRCs#4
Merged
Conversation
…ce equivalent CRCs
The logic to determine whether the CRC needed to be bit-reversed was only correct when Reflect_Output = CRC_Table_Reflected, but there were other situations when it was also needed. This defect was highlighted by the recently added tests that check such conditions.
damaki
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests check that the same CRC is output for two CRC algorithms that have identical parameters except one uses a reflected table/polynomial and the other does not. These tests cover some paths and subprograms that were not previously covered by other tests, bringing the total MC/DC code coverage up to 100%.
These tests identified a defect in the logic for determining when the final CRC needs to be bit-reversed, which is also fixed.