Skip to content

chore: Upgraded SonarAnalyzer.CSharp and disabled SonarCloud#103

Merged
samtrion merged 1 commit into
mainfrom
chore/upgraded-deps-sonarclient
Jun 11, 2025
Merged

chore: Upgraded SonarAnalyzer.CSharp and disabled SonarCloud#103
samtrion merged 1 commit into
mainfrom
chore/upgraded-deps-sonarclient

Conversation

@samtrion

Copy link
Copy Markdown
Contributor

No description provided.

@samtrion samtrion requested review from Hnogared and Copilot June 11, 2025 07:49
@samtrion samtrion self-assigned this Jun 11, 2025
@samtrion samtrion requested a review from a team as a code owner June 11, 2025 07:49
@samtrion samtrion added state:ready for merge Indicates that a pull request has been reviewed and approved, and is ready to be merged into the mai type:chore Indicates some housework that needs to be done. labels Jun 11, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the SonarAnalyzer.CSharp package and disables SonarCloud integration.

  • Upgraded SonarAnalyzer.CSharp from version 10.9.0.115408 to 10.11.0.117924 and removed the conditional build restriction.
  • Removed the enableSonarQube flag from the CI workflow to disable SonarCloud scanning.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Directory.Packages.props Updated SonarAnalyzer.CSharp with a new version and removed condition attribute
.github/workflows/cicd.yml Removed the SonarCloud enabling flag from the CI pipeline
Comments suppressed due to low confidence (2)

.github/workflows/cicd.yml:29

  • The removal of the 'enableSonarQube' flag disables SonarCloud scanning in the CI pipeline. Please ensure that any CI processes or notifications relying on SonarCloud are updated accordingly.
enableSonarQube: true

Directory.Packages.props:14

  • Removing the condition attribute causes SonarAnalyzer.CSharp to be applied universally. Please verify that this change is intentional and that builds outside Visual Studio are correctly configured without the condition.
<GlobalPackageReference Include="SonarAnalyzer.CSharp" Version="10.11.0.117924" />

@codecov

codecov Bot commented Jun 11, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.63%. Comparing base (6919f67) to head (502468e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #103   +/-   ##
=====================================
  Coverage   3.63%   3.63%           
=====================================
  Files          2       2           
  Lines         55      55           
  Branches       2       2           
=====================================
  Hits           2       2           
  Misses        53      53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samtrion samtrion merged commit a69e627 into main Jun 11, 2025
15 checks passed
@samtrion samtrion deleted the chore/upgraded-deps-sonarclient branch June 11, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:ready for merge Indicates that a pull request has been reviewed and approved, and is ready to be merged into the mai type:chore Indicates some housework that needs to be done.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants