UPDATE: new steps 'data_validation' and 'write_row_to_snowflake'#25
Open
mikaelakihitto-dadosfera wants to merge 1 commit into
Open
UPDATE: new steps 'data_validation' and 'write_row_to_snowflake'#25mikaelakihitto-dadosfera wants to merge 1 commit into
mikaelakihitto-dadosfera wants to merge 1 commit into
Conversation
guilherme-maioli
suggested changes
Dec 5, 2024
guilherme-maioli
left a comment
guilherme-maioli
left a comment
There was a problem hiding this comment.
Anotei alguns pontos que vi
| input_data = list(input_data_from_step.values())[1] | ||
|
|
||
| # Carregando o schema e validando os dados | ||
| schema_file = os.path.basename(__file__) + '.schema.json' |
There was a problem hiding this comment.
Isso aqui vai validar o schema do próprio step? Está estranho...
| input_data_from_step = orchest.get_inputs() | ||
|
|
||
| # Assumindo que o segundo item do dicionário é relevante (ajuste conforme necessário) | ||
| input_data = list(input_data_from_step.values())[1] |
There was a problem hiding this comment.
Melhor usar como dict msm e usar o get_step_param pra pegar o valor
| raw_input_data = orchest.get_inputs() | ||
| logger.debug(f"Dados de entrada do step anterior: {raw_input_data}") | ||
|
|
||
| data_registration = list(raw_input_data.values())[1][0] # Ajuste conforme o formato esperado |
There was a problem hiding this comment.
Melhor usar como dict msm e usar o get_step_param pra pegar o valor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created two new steps:
data-validation: validate the input data based in a json schema
write_row_to_snowflake: write a row to a table in snowflake