Repository navigation
Raw editor search, more decimal places, close-dialog fix - #22
Merged
Merged
Conversation
- Raw editor: Ctrl+F search bar with highlighted matches, "n of m", Enter/Shift+Enter navigation, case toggle and Esc to close. - Float options and shader constants keep up to six decimal places; the spin rows no longer round 0.125 to 0.13 or reject extra digits. - The unsaved-changes dialog on close and the raw editor's "Edited" status work again (their *_ parameter shadowed gettext).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two reported issues plus a bug found on the way.
What changed
0.125as0.13, rounded the value to that when the field lost focus and refused extra typed decimals. The display now trims trailing zeros (keeping the previous minimum) and uses the locale's decimal separator, which GTK requires when parsing._on_close(self, *_)shadowed the gettext_, so the handler raised and the window closed without asking. Same fix for the raw editor's "Edited" status.Merge notes