Skip to content

Raw editor search, more decimal places, close-dialog fix - #22

Merged
dMopp merged 1 commit into
mainfrom
raw-search-decimals
Nov 9, 2026
Merged

dMopp merged 1 commit into
mainfrom
raw-search-decimals

Conversation

@dMopp

@dMopp dMopp commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Summary

Two reported issues plus a bug found on the way.

What changed

  • Search in the raw editor (Ctrl+F) – a search bar above the text: every match is highlighted, "n of m" counter, Enter / Shift+Enter or the arrow buttons jump between matches, "Aa" matches case, Esc closes it. A selection on one line is taken as the search term; editing while the bar is open re-highlights without moving the cursor.
  • More decimal places – float options and shader constants keep up to six decimals. The spin rows had a fixed 1–3 digits, so GTK showed 0.125 as 0.13, rounded the value to that when the field lost focus and refused extra typed decimals. The display now trims trailing zeros (keeping the previous minimum) and uses the locale's decimal separator, which GTK requires when parsing.
  • Unsaved-changes dialog on close – _on_close(self, *_) shadowed the gettext _, so the handler raised and the window closed without asking. Same fix for the raw editor's "Edited" status.
  • German translations for the new strings, CHANGELOG (Unreleased) and README updated, tests for the number formatting.

Merge notes

  • No config or schema changes; nothing to migrate.
  • Tested: full test suite (88 passed) and a GTK smoke test of the spin rows and the search in German and C locale.

- Raw editor: Ctrl+F search bar with highlighted matches, "n of m",
  Enter/Shift+Enter navigation, case toggle and Esc to close.
- Float options and shader constants keep up to six decimal places;
  the spin rows no longer round 0.125 to 0.13 or reject extra digits.
- The unsaved-changes dialog on close and the raw editor's "Edited"
  status work again (their *_ parameter shadowed gettext).
@dMopp
dMopp merged commit b51700b into main Nov 9, 2026
5 checks passed
@dMopp
dMopp deleted the raw-search-decimals branch November 9, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant