Feat/carousel news scheduling#68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
News scheduling
Added news scheduling so that news items can be planned, which also means that we had to add a third branch (production) so that we can trigger daily deploys with a github workflow to rebuild.
Current:
If something's edited in the CMS admin, it saves to branch "cms-staging". When edits are ready, you can click the "publish to staging" button in the CMS, which pushes the changes to the branch "main". That makes it visible on d3i-website.github.io so that we can preview it before it goes live. Then once it's approved, I run the action manually (GitHub actions) to trigger the deploy to Netlify where it's then visible on datadonation.eu.
New:
The manual deploy action now writes it to the production branch first, then deploys to Netlify from there. This allows us to trigger a daily update via a cron job so that the future news items will display on the day they're scheduled to.
Carousel
We switched the front page to a carousel format to cut down on the text overload and also have it be distinguishable enough from the news underneath it that it looked nice.
News pages
Just a small change to the news pages. Previously if you clicked on a news item, it would open to a two-column layout and squish in the right column. This fixes it.