fix(facebook): remove no-data.txt from json_en validation file list#75
Open
daniellemccool wants to merge 1 commit into
Open
fix(facebook): remove no-data.txt from json_en validation file list#75daniellemccool wants to merge 1 commit into
daniellemccool wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no-data.txtis Facebook's empty-section placeholder, present in both JSON and HTML exports, so it can't discriminate between formats. Because it was in thejson_enknown_files list, an HTML-format DDP with several empty sections (e.g. thewhat-iftest package, 22×no-data.txt) scored ~37% against the list — far over the 5% detection threshold — and validated asjson_endespite containing zero.jsondata files.Removes the three
no-data.txtentries so detection keys only on format-specific filenames. Verified: the HTML package now scores 0% (rejected); a normal JSON DDP is unaffected (still well above threshold).As noted in the issue, this is independent of the longer-term goal of having the standard scripts accept all export formats.
Closes #74