Refactor/tighten archive types#67
Merged
Merged
Conversation
Adds a workflow that fires on push of any tag matching 'v*'. It takes that version's section from the changelog (everything between the version and the one underneath) and then creates a GitHub release using the text as the body. The release title is the tag name. git push origin v.X.Y.Z is now the entire release flow. This does mean that future releases need to have '## vX.Y.Z - YYYY-MM-DD' format (although it can also be -- or an emdash, whatever, just make sure there's a proper semver and YMD format).
chore(ci): auto-create a GitHub release on tag push
…ader Define SeekableBinaryReader Protocol (read|seek|tell) and narrow the upload-path consumers (validate.validate_zip, ZipArchiveReader) to accept only this Protocol, with path strings no longer accepted. Renames the path_to_zip/zip_path parameters and the ZipArchiveReader.zip_path attribute to 'archive' for consistency. Type narrowing makes the streaming invariant from extraction/AD0007 checkable at the typecheck layer (Pyright via 'pnpm typecheck:py'). CI doesn't currently run typecheck, so this is local code-review aid rather than a CI gate. If we combine it with the absence of materialize_file(), it's probably sufficient. Tests are refactored to ues io.BytesIO fixrues instead of tmp_path string fixtures.
trbKnl
approved these changes
May 8, 2026
Collaborator
|
Allright? Is it all ready to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define SeekableBinaryReader Protocol (read|seek|tell) and narrow the upload-path consumers (validate.validate_zip, ZipArchiveReader) to accept only this Protocol, with path strings no longer accepted. Renames the path_to_zip/zip_path parameters and the ZipArchiveReader.zip_path attribute to 'archive' for consistency.
Type narrowing makes the streaming invariant from extraction/AD0007 checkable at the typecheck layer (Pyright via 'pnpm typecheck:py'). CI doesn't currently run typecheck, so this is local code-review aid rather than a CI gate. If we combine it with the absence of materialize_file(), it's probably sufficient.
Tests are refactored to ues io.BytesIO fixrues instead of tmp_path string fixtures.