Repository navigation
Update MathJax-Go to the latest merged parity fixes - #2938
Merged
Merged
Conversation
Pin the installable main commit and add frozen-original SVG and measurement regressions for the Mathtools paired-delimiter setting and bigtimes command. - sent from alixander's Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human
AI
D2 still uses
mathjax-go v0.1.0, so it does not receive the merged parity repairs. Pinv0.1.1-0.20261002175158-94d80186bfd7, the latest merged main commit, after MathJax-Go #210 makes that source installable within Go's module archive limit.Add two frozen-MathJax 3.2.2 SVG hash and label-measurement regressions for the Mathtools paired-delimiter setting and registered
bigtimescommand. All 27 existing expectations remain unchanged. The two new cases fail withv0.1.0; all 29 pass with the new published dependency. Thebigtimeswitness explicitly supplies its bold formatter, as required by the frozen component's package set.Full paired-delimiter D2 SVGs: before, after, original MathJax 3.2.2, and original screenshot.
Full bigtimes D2 SVGs: before, after, original MathJax 3.2.2, and original screenshot.
Re-rendered the saved witnesses with the current D2 CLI before and after this update; their SVGs exactly match the linked, inspected evidence. All 31 complete D2 witness SVGs match the independent original MathJax output byte for byte. The after binary uses the downloaded, checksum-verified dependency with no local replacement. The module archive's runtime and license bytes match the tested upstream commit.
Validation passed at
daf9f6c84caab36a4eff7ff34abbace2b655a9da: full standard make checks (native tests, vet/build, executable WASM tests, JavaScript type checks, 52 unit tests, and installed ESM/CommonJS integration), the complete native race suite, and the Linux/amd64 release archive and size budget. Hosted CI, signature, both TALA fuzz jobs, all six release archives and native smoke tests, and the Windows MSI job passed. Fresh Chromium captures of the actual consumer SVGs have byte-identical fixed/original PNGs with no clipping.