hanime1.me and rule34video.com support#14
Conversation
|
Great PR! But, I've never heard about hanime1.me before. Is it a niche website? |
|
Thanks for taking a look at it! |
|
The reason I'm not including tests is because these websites—shady as they are—have no guarantees on their behavior. The hanime.tv extractor used to include a test, but it has been removed. |
Maybe you're better off making a PR in the upstream than here. The maintainers can be slow, but it would reach to a wider audience. |
|
thanks for the feedback!
is valid, but actually used an orderedset instead, to preserve playlist video order. Regarding upstream: thanks for the recommendation, yeah, i'll try to get it merged there later on |
|
Does the playlist order have to be preserved? |
|
@kosdzzew5 I tried your fork on my machine, but it fails with a HTTP 403. |
|
Thanks for testing and for the detailed log! I tried to reproduce this and couldn't, so I think the problem is on the network/client side rather than in the extractor. Repro stepsI installed the PR branch as a plugin into two clean, separate virtualenvs (nothing from my dev tree leaking in), then ran the same public URL
A 403 on every endpoint might be an IP / region block from Cloudflare. Maybe the site is IP blocked or Cloudflare is serving a challenge your client can't pass? Have you tried perhaps with curl_cffi 0.15? yt-dlp currently only accepts curl_cffi 0.10.x-0.14.x, 0.15 silently fails. Can you give more info?
If a plain browser/curl from the same box also gets 403, it's a Cloudflare block |
|
It's not IP blocked, because I could just solve the captcha and access the site. |
|
These are the logs. |
|
Hmm, I tried |
rule34video.com videos are already supported by upstream, but adding playlist and tag and search and the like.
the tests/ folder contains some end to end tests, i find them useful but may be discarded, i see you are currently not using this type of tests.