Return 400, not 500, for well-formed but non-existent ids#407
Merged
Conversation
API endpoints that resolve an id raised a generic RuntimeError from the manifest read when the id was well-formed but referenced nothing on disk (eg kata_events for a non-existent kata-id). The global error handler maps that to HTTP 500, telling the client the server broke when in fact the request named something that does not exist. Wrap each resolver (kata_version, group, cluster_manifest) so a missing entity surfaces as a RequestError (HTTP 400), while genuine failures on an entity that does exist are re-raised unchanged rather than masked as "does not exist". cluster_hierarchy likewise now raises for an id matching no kata, group or cluster instead of returning an empty hierarchy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API endpoints that resolve an id raised a generic RuntimeError from the
manifest read when the id was well-formed but referenced nothing on disk
(eg kata_events for a non-existent kata-id). The global error handler maps
that to HTTP 500, telling the client the server broke when in fact the
request named something that does not exist.
Wrap each resolver (kata_version, group, cluster_manifest) so a missing
entity surfaces as a RequestError (HTTP 400), while genuine failures on an
entity that does exist are re-raised unchanged rather than masked as
"does not exist". cluster_hierarchy likewise now raises for an id matching
no kata, group or cluster instead of returning an empty hierarchy.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com