Mini challenge5#99
Open
BigOsvaap wants to merge 14 commits into
Open
Conversation
dianaatwizeline
left a comment
dianaatwizeline
left a comment
There was a problem hiding this comment.
good PR. My biggest advice is to move the dispatch calls as I mention in the comment
| }; | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
I don't think this empty fragment <> is necessary here
| `; | ||
|
|
||
| export function CardVideoBottom({ title, description }) { | ||
| function trucateText(text) { |
There was a problem hiding this comment.
this function can live outside CardVideoBottom so that it does not get redefined on every render
| }); | ||
| setButtonClicked(false); | ||
| } else { | ||
| dispatch({ |
There was a problem hiding this comment.
As an optional challenge, try to move the dispatch calls to inside the FavoritesProvider so that way instead of exposing dispatch and need to remember the exact type of action, you expose more straightforward functions like addFavorite and deleteFavorite that take the payload as the only parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.