Mini-Challenge 4: State management#92
Open
AntonioSalazar wants to merge 122 commits into
Open
Conversation
added 30 commits
July 18, 2021 00:54
…e Navbar styles file and the indes.jx file
installed node-sass, creating my own layout now
hamburguer menu, the input field for searching videos and the user button
is also responsive
…ow the search will be available to other components
…ideo data, working on some styling
…iles, after the user enters a topic the input search form gets cleaned out
…ork when it reners the VideoDetails component
added 6 commits
August 22, 2021 23:16
cehawz
suggested changes
Aug 25, 2021
cehawz
left a comment
cehawz
left a comment
There was a problem hiding this comment.
Necesitas desacoplar la llamada al API de VideoList.provider.js
| } | ||
|
|
||
| case 'REMOVE_FROM_FAVORITES': | ||
| const favoriteVideosFromLocalStorage = localStorage.getItem('favorite_videos'); |
There was a problem hiding this comment.
Este bloque de codigo de la 29-32 debe de estar en el action.
Author
There was a problem hiding this comment.
listo! Ya movi estas lineas de codigo :)
| const history = useHistory() | ||
| useEffect(() => { | ||
| let mounted = true; | ||
| const getVideos = async () => { |
There was a problem hiding this comment.
Este get videos debes de desacoplarlo al provider para que puedas hacer unit testing. Ademas de que esta funcionalidad deberia de estar definida en el hook de youtube.
Author
There was a problem hiding this comment.
@cehawz listo, ya pase esta funcionalidad al custom hook
added 23 commits
August 25, 2021 11:59
…Fetch, I have also refactored the VideoList Provider so it does not have the api call inside of it
…custom Hook useFetch, everything seems to be working now
…Fetch, I have also refactored the VideoList Provider so it does not have the api call inside of it
…custom Hook useFetch, everything seems to be working now
…fixed that issue in the VideoListReducer
…fixed that issue in the VideoListReducer
…e VideoListReducer to the VideoListProvider, I have also changed the favicon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Site can be visited in here: https://youtube-clone-wizeline.netlify.app/