Mini challenge4#89
Open
BigOsvaap wants to merge 12 commits into
Open
Conversation
dianaatwizeline
left a comment
dianaatwizeline
left a comment
There was a problem hiding this comment.
Good job on this PR. Keep it up!
| const urlVideo = `/watch?v=${id}`; | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
I think you can remove <> because <LinkVideo> is wrapping everything else
| }, [videos]); | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
Same comment here, you can remove <>. You only need the empty brackets when there is not one single parent element.
| `; | ||
|
|
||
| export function CardVideoBottom({ title, description }) { | ||
| function trucateText(text) { |
There was a problem hiding this comment.
It is better that this function lives outside the component
or
to not have this function definition at all and have a constant for truncated text const truncatedText = text.length [...]
the advantage of either of these options is that then the function would not be redefined with every render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.