Skip to content

Fourth deliverable/karen rodriguez#100

Open
kleyla wants to merge 52 commits into
cvillanueva84:masterfrom
kleyla:fourth-deliverable/karen-rodriguez
Open

Fourth deliverable/karen rodriguez#100
kleyla wants to merge 52 commits into
cvillanueva84:masterfrom
kleyla:fourth-deliverable/karen-rodriguez

Conversation

@kleyla

@kleyla kleyla commented Aug 26, 2021

Copy link
Copy Markdown

Description

Add Router and Auth.
Preview URL: https://kleyla.github.io/react-certification-2021/

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
💯 Add tests
🔗 Update dependencies
📜 Docs

Captura de pantalla de 2021-08-29 16-14-52

@cylcrow

cylcrow commented Aug 28, 2021

Copy link
Copy Markdown

@kleyla, good job.

There are work left, I sent you feedback and suggestions on Slack, please check them.

Acceptance Criteria

  • All the sections have their own route.
  • Navigation across the sections is implemented correctly.
  • The Global State is persistent across all the sections.
  • The "Mocked Authentication" mechanism works correctly.
  • The "session data" is stored in the Global Context correctly.
  • Videos can be added to the Favorites list.
  • Videos can be removed from the Favorites list.
  • Navigation to Favorite Videos View using a private route is implemented correctly (only authenticated users should access this section).
  • Navigation to the Favorite Video Details View using a private route is implemented correctly (only authenticated users should access this section).
  • Information for the selected favorite video is displayed correctly
  • The list of other favorite videos in the Favorite Video Details View is displayed.
  • Testing coverage is above 70%. (Please include a screenshot of the code coverage report in your PR description).

Bonus Points

  • The Add/remove from favorites button should appear when the user passes the mouse over the video card in the list.
  • Integrate with a real authentication provider (such as Auth0, OAuth or Firebase).
  • A 404 section is shown when a route is not found.
  • The Login View is implemented as a modal using React Portals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants