ACFA-694: Determine Aeon location based on the presence of barcode#254
Open
wtomaszewska wants to merge 1 commit into
Open
ACFA-694: Determine Aeon location based on the presence of barcode#254wtomaszewska wants to merge 1 commit into
wtomaszewska wants to merge 1 commit into
Conversation
…emove collection_offsite_ssi field; adjust tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ACFA-694
Do not merge; this work depends on FOLIOSYNC-18.
This PR modifies the logic for determining whether an item’s location is "Offsite" to use the presence of a barcode (items with barcodes are located offsite). We also no longer need to store
collection_offsite_ssi, as it was used only to construct the data sent to Aeon.Example Aeon request for 2 items: the first item doesn’t have a barcode, and the second does.
