Skip to content

Pretty formatter options#107

Merged
ilanpillemer merged 6 commits into
cucumber:masterfrom
muhqu:pretty-formatter-options
Mar 15, 2015
Merged

Pretty formatter options#107
ilanpillemer merged 6 commits into
cucumber:masterfrom
muhqu:pretty-formatter-options

Conversation

@muhqu

@muhqu muhqu commented Feb 24, 2015

Copy link
Copy Markdown
Member

Adds some new formatting options to the Gherkin Formatter, that are currently pending in a separat PR (cucumber/gherkin#331).

How it looks like...

screen shot 2015-02-24 at 09 12 04

cucumber-preferences

nice to have future improvements

  • allow for project specific preferences via property page

@muhqu muhqu mentioned this pull request Feb 24, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 any help to get these formatter options configurable for the user on a per-project basis would be much appreciated...

@muhqu

muhqu commented Mar 13, 2015

Copy link
Copy Markdown
Member Author

@ilanpillemer what do you think? …worth pulling? :shipit:

@ilanpillemer

Copy link
Copy Markdown
Contributor

On Friday, March 13, 2015, Mathias Leppich notifications@github.com wrote:

@ilanpillemer https://github.com/ilanpillemer what do you think? …worth
pulling? [image: :shipit:]

In two minds. I don't like separating pretty format logic from gherkin. But
if gherkin is still doing the syntax validation then perhaps it's not so
bad.


Reply to this email directly or view it on GitHub
#107 (comment)
.

@muhqu

muhqu commented Mar 13, 2015

Copy link
Copy Markdown
Member Author

[...] separating pretty format logic from gherkin.

@ilanpillemer I don't know what you mean by that.

If you're referring to the copy of PrettyFormatter.java in this PR. It is the same that is waiting to get merged into gherkin. See cucumber/gherkin#331.

@ilanpillemer

Copy link
Copy Markdown
Contributor

On Friday, March 13, 2015, Mathias Leppich notifications@github.com wrote:

[...] separating pretty format logic from gherkin.

@ilanpillemer https://github.com/ilanpillemer I don't know what you
mean by that.

If you're referring to the copy of PrettyFormatter.java in this PR. It is
the same that is waiting to get merged into gherkin
https://github.com/cucumber/gherkin/. See cucumber/gherkin#331
cucumber/gherkin#331.

Ok. I see Aslak says they are all on Gherkin3.

I will merge your changes in over the weekend for this one then seeing this
version of Gherkin is clearly going out anyway.


Reply to this email directly or view it on GitHub
#107 (comment)
.

ilanpillemer added a commit that referenced this pull request Mar 15, 2015
@ilanpillemer ilanpillemer merged commit f7d6ed9 into cucumber:master Mar 15, 2015
@muhqu

muhqu commented Mar 16, 2015

Copy link
Copy Markdown
Member Author

@ilanpillemer thanks for merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants