Change default value for element_type_column parameter to ElementType…

[wimgielis]

… instead of Type

tm1.elements.get_elements_dataframe() has a default value of "Type" for element_type_column. tm1.hierarchies.update_or_create_hierarchy_from_dataframe() has a default value of "ElementType" for element_type_column.

This seems to add unnecessary downstream work.

[MariusWirtz]

@wimgielis I hear you.
It would have been the right decision to call it "ElementType" when we initially wrote it.

We can't change the name of the column now, as it wouldn't be backwards compatible and break countless scripts on upgrade.

Any other ideas to avoid the pitfall and the renaming work (for the column name mismatch) when using both functions together?

Perhaps we can make the update_or_create_hierarchy_from_dataframe more lenient to accept Type as the element type column if ElementType isn't provided in the df?
Just thinking loud...

[wimgielis]

Hello Marius, that suggestion seems good to me considering indeed that the rename change in the code now is too late.

…

------ Op ma 8 jun 2026 om 10:15 schreef Marius Wirtz ***@***.***>

*MariusWirtz* left a comment (cubewise-code/tm1py#1414) <#1414 (comment)> @wimgielis <https://github.com/wimgielis> I hear you. It would have been the right decision to call it "ElementType" when we initially wrote it. We can't change the name of the column now, as it wouldn't be backwards compatible and break countless scripts on upgrade. Any other ideas to avoid the pitfall and the renaming work (for the column name mismatch) when using both functions together? Perhaps we can make the update_or_create_hierarchy_from_dataframe more lenient to accept Type as the element type column if ElementType isn't provided in the df? Just thinking loud... — Reply to this email directly, view it on GitHub <#1414?email_source=notifications&email_token=AEDHULPZ7IFMWPJKFJD23K346ZYYJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRUGY3DOMZTGAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4646673303>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEDHULKODC4EWD7YXQ26GLD46ZYYJAVCNFSM6AAAAACZ4PVZN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DMNBWGY3TGMZQGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[MariusWirtz]

Closed for #1418