OCM: implement new webapp protocol#274
Merged
Merged
Conversation
glpatcern
commented
Jun 10, 2026
Member
|
nice 😄 |
rawe0
reviewed
Jun 12, 2026
glpatcern
force-pushed
the
ocm-new-webapp
branch
from
9993c4c to
5f6fa01
Compare
glpatcern
force-pushed
the
ocm-new-webapp
branch
from
e80f40d to
da798a0
Compare
glpatcern
commented
Jun 14, 2026
rawe0
approved these changes
Jun 15, 2026
rawe0
left a comment
rawe0
left a comment
Member
There was a problem hiding this comment.
Can be merged from my perspective, I'm happy with this.
Member
Author
|
Given that this is backwards-compatible for OCM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce support for the new payload of OCM
webappshares, as discussed and agreed in cs3org/OCM-API#368.We're also adding an optional
hiddenfield to the ocm.ReceivedShare message, similar toReceivedShare.hidden.This is a breaking change, which we agreed within the OCM collaboration as the only working implementation of webapps is/was CERNBox, with the PoC we have done a few years ago. For this reason I didn't leave the dropped fields as
[deprecated]. We plan to adapt our implementation to the new payload in the coming weeks.In addition, the
permissionsfor both thewebdavandwebappOCM protocols were reviewed: we now use theResourcePermissionsmessage as opposed to a custom OCM message that did not bring any added value. The corresponding field for thewebdavprotocol is marked as[deprecated].