ocm: add TRANSFERRING share state#273
Merged
Merged
Conversation
rawe0
approved these changes
May 28, 2026
rawe0
left a comment
rawe0
left a comment
Member
There was a problem hiding this comment.
Looks good to me, since it's new functionality it will not break anything.
glpatcern
force-pushed
the
ocm-add-share-state
branch
from
239e6c8 to
4f032f6
Compare
jessegeens
approved these changes
May 28, 2026
3 tasks
flash7777
pushed a commit
to flash7777/reva
that referenced
this pull request
Jun 11, 2026
Update to the latest go-cs3apis which includes three upstream changes: 1. cs3org/cs3apis#272 — container-specific permissions + immutable RPCs 2. cs3org/cs3apis#273 — OCM share state changes 3. Labels API moved from StorageProvider to cs3/labels/v1beta1 Labels API migration: Before (old cs3apis): ┌──────────┐ AddLabel/RemoveLabel ┌─────────────────┐ │ opencloud├──────────────────────────►│ Gateway │ │ (graph) │ provider.AddLabelReq │ │ └──────────┘ │ ┌─────────────┐ │ │ │ find(ref) │ │ │ └──────┬──────┘ │ └─────────┼────────┘ │ c.AddLabel() ┌─────────▼────────┐ │ StorageProvider │ │ (ProviderAPI) │ │ → Storage.Add... │ └──────────────────┘ After (new cs3apis): ┌──────────┐ AddLabel/RemoveLabel ┌─────────────────┐ │ opencloud├──────────────────────────►│ Gateway │ │ (graph) │ labels.AddLabelReq │ │ └──────────┘ │ returns │ │ UNIMPLEMENTED │ │ (TODO: wire to │ │ LabelsAPI svc) │ └─────────────────┘ ╳ not yet wired ┌─────────────────┐ │ StorageProvider │ │ (LabelsAPI svc) │ │ → Storage.Add.. │ └─────────────────┘ The StorageProvider now registers as LabelsAPIServer (in addition to ProviderAPIServer and SpacesAPIServer), so AddLabel/RemoveLabel still work at the storage level. The Gateway needs to be wired to call the LabelsAPI service on the StorageProvider — this requires extending the gateway client pool to support LabelsAPIClient. For now, Gateway returns CODE_UNIMPLEMENTED for Labels calls. This temporarily breaks favorites in opencloud until the wiring is completed (separate PR). Changes: - go.mod: bump go-cs3apis - StorageProvider: register as LabelsAPIServer, implement AddLabel/ RemoveLabel/ListLabels/ListResourcesForLabel - Gateway: Labels stubs (UNIMPLEMENTED, TODO: wire to LabelsAPI) - Add SetImmutable/UnsetImmutable stubs to all ProviderAPI implementations - Regenerate mocks
flash7777
pushed a commit
to flash7777/reva
that referenced
this pull request
Jun 11, 2026
Update to the latest go-cs3apis which includes three upstream changes: 1. cs3org/cs3apis#272 — container-specific permissions + immutable RPCs 2. cs3org/cs3apis#273 — OCM share state changes 3. Labels API moved from StorageProvider to cs3/labels/v1beta1 Labels API migration: Before: opencloud -> Gateway -> StorageProvider (ProviderAPI.AddLabel) After: opencloud -> Gateway -> StorageProvider (LabelsAPI.AddLabel) The StorageProvider now registers as LabelsAPIServer in addition to ProviderAPIServer and SpacesAPIServer. The Gateway routes Labels calls to the StorageProvider via a new LabelsAPIClient, using the same GRPC connection pool. Changes: - go.mod: bump go-cs3apis - StorageProvider: register as LabelsAPIServer, implement AddLabel/RemoveLabel via Storage FS interface - Gateway: route AddLabel/RemoveLabel to StorageProvider's LabelsAPI - Pool: add LabelsProviderSelector and GetLabelsProviderServiceClient - Add SetImmutable/UnsetImmutable to all ProviderAPI implementations - Regenerate mocks
flash7777
pushed a commit
to flash7777/reva
that referenced
this pull request
Jun 14, 2026
Update to the latest go-cs3apis which includes three upstream changes: 1. cs3org/cs3apis#272 — container-specific permissions + immutable RPCs 2. cs3org/cs3apis#273 — OCM share state changes 3. Labels API moved from StorageProvider to cs3/labels/v1beta1 Labels API migration: Before: opencloud -> Gateway -> StorageProvider (ProviderAPI.AddLabel) After: opencloud -> Gateway -> StorageProvider (LabelsAPI.AddLabel) The StorageProvider now registers as LabelsAPIServer in addition to ProviderAPIServer and SpacesAPIServer. The Gateway routes Labels calls to the StorageProvider via a new LabelsAPIClient, using the same GRPC connection pool. Changes: - go.mod: bump go-cs3apis - StorageProvider: register as LabelsAPIServer, implement AddLabel/RemoveLabel via Storage FS interface - Gateway: route AddLabel/RemoveLabel to StorageProvider's LabelsAPI - Pool: add LabelsProviderSelector and GetLabelsProviderServiceClient - Add SetImmutable/UnsetImmutable to all ProviderAPI implementations - Regenerate mocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.